Added support for GitHub App auth#482
Conversation
|
Hi @sabre1041. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sabre1041
force-pushed
the
github-app-auth
branch
from
97d5633 to
728fb24
Compare
|
/ok-to-test |
|
Thanks @sabre1041 this lgtm. The only thing we will need to figure out is how to clone the git repo in the imperative bits here https://github.com/validatedpatterns/clustergroup-chart/blob/main/templates/imperative/_helpers.tpl#L49-L62. I suspect the time has come to rip that bandaid out and replace it with a tiny go binary that uses the argo pkgs to do the right thing in regards to git cloning for the imperative jobs. |
sabre1041
force-pushed
the
github-app-auth
branch
from
728fb24 to
dbee938
Compare
|
/ok-to-test |
| BeforeEach(func() { | ||
| clientset = fake.NewSimpleClientset() | ||
| secret = map[string][]byte{ | ||
| "githubAppPrivateKey": []byte(`-----BEGIN RSA PRIVATE KEY----- |
There was a problem hiding this comment.
Can we include a comment here that this is not a real/active private key?
|
/ok-to-test |
Signed-off-by: Andrew Block <andy.block@gmail.com>
sabre1041
force-pushed
the
github-app-auth
branch
from
dbee938 to
061f997
Compare
|
@mbaldessari latest enhancement should address and resolve the failures experienced previously Let me know if theres anything else that I'd be able to provide so that we would be able to integrate this feature |
|
/ok-to-test |
|
/lgtm |
|
/approve |
|
thanks @sabre1041 ! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbaldessari, sabre1041 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
openshift-merge-bot
Bot
merged commit cad345d
into
validatedpatterns:main
3 participants
Added support to authenticate using a GitHub App.
Related to #443