Try cursor suggestsions

Author: Martin Jackson

charts/hub/opp/templates/placement-binding-hub.yaml

@@ -5,11 +5,12 @@ metadata:
     open-cluster-management.io/policy-set: openshift-plus
   name: binding-policy-openshift-plus-hub
   namespace: policies
-placementRef:
-  apiGroup: cluster.open-cluster-management.io
-  kind: Placement
-  name: placement-openshift-plus-hub
-subjects:
-- apiGroup: policy.open-cluster-management.io
-  kind: PolicySet
-  name: openshift-plus-hub
+spec:
+  placementRef:
+    apiGroup: cluster.open-cluster-management.io
+    kind: Placement
+    name: placement-openshift-plus-hub
+  subjects:
+  - apiGroup: policy.open-cluster-management.io
+    kind: PolicySet
+    name: openshift-plus-hub

charts/hub/opp/templates/placement-binding-managed.yaml

@@ -5,11 +5,12 @@ metadata:
     open-cluster-management.io/policy-set: openshift-plus
   name: binding-policy-openshift-plus-managed
   namespace: policies
-placementRef:
-  apiGroup: cluster.open-cluster-management.io
-  kind: Placement
-  name: placement-openshift-plus-managed
-subjects:
-- apiGroup: policy.open-cluster-management.io
-  kind: PolicySet
-  name: openshift-plus-managed
+spec:
+  placementRef:
+    apiGroup: cluster.open-cluster-management.io
+    kind: Placement
+    name: placement-openshift-plus-managed
+  subjects:
+  - apiGroup: policy.open-cluster-management.io
+    kind: PolicySet
+    name: openshift-plus-managed

charts/hub/opp/templates/policy-ocm-observability.yaml

@@ -35,11 +35,11 @@ spec:
               thanos.yaml: |
                 type: s3
                 config:
-                  bucket: '{{ `{{ (lookup "objectbucket.io/v1alpha1" "ObjectBucket" "" "obc-openshift-storage-obc-observability").spec.endpoint.bucketName }}` }}'
-                  endpoint: '{{ `{{ (lookup "objectbucket.io/v1alpha1" "ObjectBucket" "" "obc-openshift-storage-obc-observability").spec.endpoint.bucketHost }}` }}'
+                  bucket: "{{ (lookup "objectbucket.io/v1alpha1" "ObjectBucket" "" "obc-openshift-storage-obc-observability").spec.endpoint.bucketName | default "obc-observability-bucket" }}"
+                  endpoint: "{{ (lookup "objectbucket.io/v1alpha1" "ObjectBucket" "" "obc-openshift-storage-obc-observability").spec.endpoint.bucketHost | default "s3.openshift-storage.svc.cluster.local" }}"
                   insecure: false
-                  access_key: '{{ `{{ (lookup "v1" "Secret" "openshift-storage" "noobaa-admin").data.AWS_ACCESS_KEY_ID | base64dec }}` }}'
-                  secret_key: '{{ `{{ (lookup "v1" "Secret" "openshift-storage" "noobaa-admin").data.AWS_SECRET_ACCESS_KEY | base64dec }}` }}'
+                  access_key: "{{ (lookup "v1" "Secret" "openshift-storage" "noobaa-admin").data.AWS_ACCESS_KEY_ID | b64dec | default "placeholder" }}"
+                  secret_key: "{{ (lookup "v1" "Secret" "openshift-storage" "noobaa-admin").data.AWS_SECRET_ACCESS_KEY | b64dec | default "placeholder" }}"
                   http_config:
                     insecure_skip_verify: true
                     tls_config:
@@ -50,6 +50,7 @@ spec:
             kind: MultiClusterObservability
             metadata:
               name: observability
+              namespace: open-cluster-management-observability
             spec:
               observabilityAddonSpec: {}
               storageConfig:

values-hub.yaml

@@ -3,6 +3,7 @@ clusterGroup:
   isHubCluster: true
   namespaces:
     - open-cluster-management
+    - open-cluster-management-observability
     - vault
     - golang-external-secrets
     - regional-dr
@@ -69,8 +70,16 @@ clusterGroup:
         automated: {}
         retry:
           limit: 20
+          backoff:
+            duration: 5s
+            factor: 2
+            maxDuration: 3m
         syncOptions:
-          - syncTimeout=600s
+          - syncTimeout=1800s
+          - CreateNamespace=true
+          - PrunePropagationPolicy=foreground
+          - RespectIgnoreDifferences=true
+          - ServerSideApply=true
       ignoreDifferences:
       - group: operators.openshift.io
         kind: Console