Skip to content

Commit 8552e88

Browse files
Martin Jacksoncursoragent
andcommitted
test(parse_secrets): align expectations with validation paths
- none backend rejects generate in _validate_one_secret_entry with a distinct message. - invalid secrets_phase is rejected by AnsibleModule choices; use msg (args[1] is absent). Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent b3032d6 commit 8552e88

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

tests/unit/test_parse_secrets.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -928,7 +928,7 @@ def test_ensure_generate_errors_on_none_generate(self, getpass):
928928
self.assertEqual(ret["failed"], True)
929929
assert (
930930
ret["args"][1]
931-
== "You cannot have onMissingValue set to 'generate' unless using vault backingstore for secret config-demo field secret" # noqa: E501
931+
== "Secret config-demo field secret cannot use onMissingValue generate with secrets backend none" # noqa: E501
932932
)
933933

934934
def test_ensure_success_empty_secrets(self, getpass):
@@ -1270,7 +1270,17 @@ def test_invalid_secrets_phase_fails(self, getpass):
12701270

12711271
ret = ansible_err.exception.args[0]
12721272
self.assertEqual(ret["failed"], True)
1273-
assert "secrets_phase must be 'early' or 'late'" in ret["args"][1]
1273+
# Invalid choice fails in AnsibleModule before run(); message is in msg, not args[1].
1274+
msg = ret.get("msg") or (
1275+
ret["args"][1] if len(ret.get("args", ())) > 1 else ""
1276+
)
1277+
self.assertIn("early", msg)
1278+
self.assertIn("late", msg)
1279+
self.assertTrue(
1280+
"secrets_phase must be 'early' or 'late'" in msg
1281+
or "midnight" in msg.lower(),
1282+
msg,
1283+
)
12741284

12751285

12761286
if __name__ == "__main__":

0 commit comments

Comments
 (0)