Skip to content

Commit 042d5a7

Browse files
author
Martin Jackson
committed
Update docs and default to maximum automation
1 parent ae7949e commit 042d5a7

3 files changed

Lines changed: 105 additions & 29 deletions

File tree

README.md

Lines changed: 52 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,37 +6,75 @@ Wrapper Helm chart for Stakater Reloader with defaults for cluster-wide OpenShif
66

77
## Prerequisites
88

9-
- Helm 3 or later
109
- OpenShift (or Kubernetes) cluster
10+
- A [Validated Patterns](https://validatedpatterns.io/) deployment (for example [multicloud-gitops](https://github.com/validatedpatterns/multicloud-gitops)) with `clusterGroup` hub values, or Helm 3 if you install the chart directly
1111
- Optional: [Secrets Store CSI Driver](https://secrets-store-csi-driver.sigs.k8s.io/) and its CRDs if you rely on CSI-backed secret rotation (Reloader watches those APIs when `reloader.reloader.enableCSIIntegration` is true)
1212

1313
## Install
1414

15-
Add this chart (or your chart repo) and install into a dedicated namespace, for example `reloader`:
16-
17-
```bash
18-
helm install reloader /path/to/vp-stakater-reloader-chart \
19-
--namespace reloader \
20-
--create-namespace
15+
### Validated Patterns (`clusterGroup`)
16+
17+
Declare a dedicated namespace and an Argo CD application in your hub (or site) values, alongside an `argoProject` that already exists in the same file. When this chart is published to the [Validated Patterns Helm charts](https://github.com/validatedpatterns/helm-charts) repository, reference it by chart name and a `0.1.*` version range (same style as other catalog charts in multicloud-gitops `values-hub.yaml`):
18+
19+
```yaml
20+
clusterGroup:
21+
namespaces:
22+
vp-stakater-reloader:
23+
argoProjects:
24+
- hub
25+
# ... other projects ...
26+
applications:
27+
vp-stakater-reloader:
28+
name: vp-stakater-reloader
29+
namespace: vp-stakater-reloader
30+
argoProject: hub
31+
chart: vp-stakater-reloader
32+
chartVersion: 0.1.*
2133
```
2234
35+
Ensure `argoProjects` includes the `argoProject` you reference. To deploy from a Git source instead of the catalog, use `repoURL`, `chartVersion` (target revision), and `path` as in the upstream Reloader chart packaging workflows.
36+
2337
### OpenShift UID / SCC (recommended)
2438

25-
Upstream Reloader defaults `runAsUser: 65534`. On OpenShift 4.13+, Stakater recommends letting the namespace SCC assign the UID. Helm value merging keeps that default unless you clear the key explicitly:
39+
Upstream Reloader defaults `runAsUser: 65534`. On OpenShift 4.13+, Stakater recommends letting the namespace SCC assign the UID. In a Validated Patterns application, use Helm overrides on the application entry (Helm value merging keeps the default unless you clear the key):
40+
41+
```yaml
42+
vp-stakater-reloader:
43+
# ... name, namespace, argoProject, chart, chartVersion ...
44+
overrides:
45+
- name: reloader.reloader.deployment.securityContext.runAsUser
46+
value: "null"
47+
```
48+
49+
Standalone Helm equivalent:
2650

2751
```bash
28-
helm install reloader /path/to/vp-stakater-reloader-chart \
29-
--namespace reloader \
52+
helm install vp-stakater-reloader /path/to/vp-stakater-reloader-chart \
53+
--namespace vp-stakater-reloader \
3054
--create-namespace \
3155
--set reloader.reloader.deployment.securityContext.runAsUser=null
3256
```
3357

34-
### Maximum automation (`autoReloadAll`)
58+
### Annotation-only reloads (`autoReloadAll`)
3559

36-
This chart sets `reloader.reloader.autoReloadAll` to `false` so workloads opt in via Reloader annotations. To reload on ConfigMap/Secret changes by default (opt out with `reloader.stakater.com/auto: "false"` on a workload), set:
60+
By default `reloader.reloader.autoReloadAll` is `true`, so Reloader rolls workloads on ConfigMap or Secret changes unless you opt a workload out with `reloader.stakater.com/auto: "false"`. To require explicit Reloader annotations on every workload instead, set:
61+
62+
```yaml
63+
overrides:
64+
- name: reloader.reloader.autoReloadAll
65+
value: "false"
66+
```
67+
68+
Standalone Helm: `--set reloader.reloader.autoReloadAll=false`.
69+
70+
### Direct Helm install
71+
72+
If you are not using Validated Patterns, install from a clone or packaged chart:
3773

3874
```bash
39-
--set reloader.reloader.autoReloadAll=true
75+
helm install vp-stakater-reloader /path/to/vp-stakater-reloader-chart \
76+
--namespace vp-stakater-reloader \
77+
--create-namespace
4078
```
4179

4280
## Upstream documentation
@@ -74,7 +112,7 @@ make helm-deps
74112

75113
| Key | Type | Default | Description |
76114
|-----|------|---------|-------------|
77-
| reloader.reloader.autoReloadAll | bool | `false` | Reload on ConfigMap or Secret changes by default; opt out per workload via Reloader annotations |
115+
| reloader.reloader.autoReloadAll | bool | `true` | Reload on ConfigMap or Secret changes by default; opt out per workload with reloader.stakater.com/auto: "false" |
78116
| reloader.reloader.deployment.replicas | int | `2` | Number of controller replicas (requires enableHA when greater than 1) |
79117
| reloader.reloader.deployment.securityContext.runAsNonRoot | bool | `true` | Run as non-root |
80118
| reloader.reloader.deployment.securityContext.seccompProfile.type | string | `"RuntimeDefault"` | Seccomp profile for the pod |

README.md.gotmpl

Lines changed: 51 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,37 +7,75 @@
77

88
## Prerequisites
99

10-
- Helm 3 or later
1110
- OpenShift (or Kubernetes) cluster
11+
- A [Validated Patterns](https://validatedpatterns.io/) deployment (for example [multicloud-gitops](https://github.com/validatedpatterns/multicloud-gitops)) with `clusterGroup` hub values, or Helm 3 if you install the chart directly
1212
- Optional: [Secrets Store CSI Driver](https://secrets-store-csi-driver.sigs.k8s.io/) and its CRDs if you rely on CSI-backed secret rotation (Reloader watches those APIs when `reloader.reloader.enableCSIIntegration` is true)
1313

1414
## Install
1515

16-
Add this chart (or your chart repo) and install into a dedicated namespace, for example `reloader`:
17-
18-
```bash
19-
helm install reloader /path/to/vp-stakater-reloader-chart \
20-
--namespace reloader \
21-
--create-namespace
16+
### Validated Patterns (`clusterGroup`)
17+
18+
Declare a dedicated namespace and an Argo CD application in your hub (or site) values, alongside an `argoProject` that already exists in the same file. When this chart is published to the [Validated Patterns Helm charts](https://github.com/validatedpatterns/helm-charts) repository, reference it by chart name and a `0.1.*` version range (same style as other catalog charts in multicloud-gitops `values-hub.yaml`):
19+
20+
```yaml
21+
clusterGroup:
22+
namespaces:
23+
vp-stakater-reloader:
24+
argoProjects:
25+
- hub
26+
# ... other projects ...
27+
applications:
28+
vp-stakater-reloader:
29+
name: vp-stakater-reloader
30+
namespace: vp-stakater-reloader
31+
argoProject: hub
32+
chart: vp-stakater-reloader
33+
chartVersion: 0.1.*
2234
```
2335

36+
Ensure `argoProjects` includes the `argoProject` you reference. To deploy from a Git source instead of the catalog, use `repoURL`, `chartVersion` (target revision), and `path` as in the upstream Reloader chart packaging workflows.
37+
2438
### OpenShift UID / SCC (recommended)
2539

26-
Upstream Reloader defaults `runAsUser: 65534`. On OpenShift 4.13+, Stakater recommends letting the namespace SCC assign the UID. Helm value merging keeps that default unless you clear the key explicitly:
40+
Upstream Reloader defaults `runAsUser: 65534`. On OpenShift 4.13+, Stakater recommends letting the namespace SCC assign the UID. In a Validated Patterns application, use Helm overrides on the application entry (Helm value merging keeps the default unless you clear the key):
41+
42+
```yaml
43+
vp-stakater-reloader:
44+
# ... name, namespace, argoProject, chart, chartVersion ...
45+
overrides:
46+
- name: reloader.reloader.deployment.securityContext.runAsUser
47+
value: "null"
48+
```
49+
50+
Standalone Helm equivalent:
2751

2852
```bash
29-
helm install reloader /path/to/vp-stakater-reloader-chart \
30-
--namespace reloader \
53+
helm install vp-stakater-reloader /path/to/vp-stakater-reloader-chart \
54+
--namespace vp-stakater-reloader \
3155
--create-namespace \
3256
--set reloader.reloader.deployment.securityContext.runAsUser=null
3357
```
3458

35-
### Maximum automation (`autoReloadAll`)
59+
### Annotation-only reloads (`autoReloadAll`)
3660

37-
This chart sets `reloader.reloader.autoReloadAll` to `false` so workloads opt in via Reloader annotations. To reload on ConfigMap/Secret changes by default (opt out with `reloader.stakater.com/auto: "false"` on a workload), set:
61+
By default `reloader.reloader.autoReloadAll` is `true`, so Reloader rolls workloads on ConfigMap or Secret changes unless you opt a workload out with `reloader.stakater.com/auto: "false"`. To require explicit Reloader annotations on every workload instead, set:
62+
63+
```yaml
64+
overrides:
65+
- name: reloader.reloader.autoReloadAll
66+
value: "false"
67+
```
68+
69+
Standalone Helm: `--set reloader.reloader.autoReloadAll=false`.
70+
71+
### Direct Helm install
72+
73+
If you are not using Validated Patterns, install from a clone or packaged chart:
3874

3975
```bash
40-
--set reloader.reloader.autoReloadAll=true
76+
helm install vp-stakater-reloader /path/to/vp-stakater-reloader-chart \
77+
--namespace vp-stakater-reloader \
78+
--create-namespace
4179
```
4280

4381
## Upstream documentation

values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ reloader:
1515
ignoreJobs: false
1616
# -- Exclude CronJobs from reload monitoring
1717
ignoreCronJobs: false
18-
# -- Reload on ConfigMap or Secret changes by default; opt out per workload via Reloader annotations
19-
autoReloadAll: false
18+
# -- Reload on ConfigMap or Secret changes by default; opt out per workload with reloader.stakater.com/auto: "false"
19+
autoReloadAll: true
2020
# -- Enable leader election for multiple replicas
2121
enableHA: true
2222
# -- Trigger rollouts when new ConfigMaps or Secrets appear

0 commit comments

Comments
 (0)