chore: update to eslint 8

Author: Rik Smale

.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "extends": "airbnb-base",
-  "parser": "babel-eslint",
+  "parser": "@babel/eslint-parser",
   "parserOptions": {
     "ecmaVersion": 6,
     "sourceType": "module"
@@ -14,13 +14,6 @@
   "rules": {
     "camelcase": 0,
     "no-param-reassign": 0,
-    "one-var": 0,
-    "one-var-declaration-per-line": 0,
-    "func-names": 0,
-    "no-console": 0,
-    "newline-per-chained-call": 0,
-    "prefer-const": 0,
-    "linebreak-style": 0,
     "no-restricted-syntax": [2, "DebuggerStatement", "LabeledStatement", "WithStatement"],
     "no-restricted-globals": 0,
     "prefer-destructuring": 0,

.github/workflows/ci.yml

@@ -20,8 +20,13 @@ jobs:
       uses: actions/checkout@v4
     - name: Install dependencies
       run: npm install --legacy-peer-deps
+    - if: matrix.node-version == 22
+      name: Run lint
+      run: npm run lint
+    - name: Run build
+      run: npm run build
     - name: Run tests
-      run: npm test
+      run: npm run test:ci
     - if: matrix.node-version == 22
       name: Send coverage info to Codecov
       uses: codecov/codecov-action@v5

package.json

@@ -40,10 +40,10 @@
     "@babel/core": "^7.0.0",
     "@babel/preset-env": "^7.0.0",
     "@babel/register": "^7.0.0",
-    "babel-eslint": "^10.0.1",
+    "@babel/eslint-parser": "^7.0.0",
     "babel-plugin-add-module-exports": "^1.0.0",
-    "eslint": "^4.19.1",
-    "eslint-config-airbnb-base": "^12.1.0",
+    "eslint": "^8.57.1",
+    "eslint-config-airbnb-base": "^15.0.0",
     "eslint-plugin-import": "^2.11.0",
     "mocha": "^6.2.3",
     "npm-run-all": "^4.1.5",
@@ -67,7 +67,8 @@
     "build:node": "babel src -d .",
     "build": "run-p build:*",
     "pretest": "npm run build && npm run lint",
-    "test": "nyc --reporter=cobertura --reporter=text-summary mocha --require @babel/register --reporter dot --recursive"
+    "test": "npm run test:ci",
+    "test:ci": "nyc --reporter=cobertura --reporter=text-summary mocha --require @babel/register --reporter dot --recursive"
   },
   "engines": {
     "node": ">= 0.10"

src/lib/alpha.js

@@ -31,10 +31,10 @@ export const alpha = {
   'vi-VN': /^[A-ZÀÁẠẢÃÂẦẤẬẨẪĂẰẮẶẲẴĐÈÉẸẺẼÊỀẾỆỂỄÌÍỊỈĨÒÓỌỎÕÔỒỐỘỔỖƠỜỚỢỞỠÙÚỤỦŨƯỪỨỰỬỮỲÝỴỶỸ]+$/i,
   'ko-KR': /^[ㄱ-ㅎㅏ-ㅣ가-힣]*$/,
   'ku-IQ': /^[ئابپتجچحخدرڕزژسشعغفڤقکگلڵمنوۆھەیێيطؤثآإأكضصةظذ]+$/i,
-  ar: /^[ءآأؤإئابةتثجحخدذرزسشصضطظعغفقكلمنهوىيًٌٍَُِّْٰ]+$/,
+  ar: /^[ءآأؤإئابةتثجحخدذرزسشصضطظعغفقكلمنهوىيًٌٍَُِّْٰ]+$/, // eslint-disable-line no-misleading-character-class
   he: /^[א-ת]+$/,
   fa: /^['آاءأؤئبپتثجچحخدذرزژسشصضطظعغفقکگلمنوهةی']+$/i,
-  bn: /^['ঀঁংঃঅআইঈউঊঋঌএঐওঔকখগঘঙচছজঝঞটঠডঢণতথদধনপফবভমযরলশষসহ়ঽািীুূৃৄেৈোৌ্ৎৗড়ঢ়য়ৠৡৢৣৰৱ৲৳৴৵৶৷৸৹৺৻']+$/,
+  bn: /^['ঀঁংঃঅআইঈউঊঋঌএঐওঔকখগঘঙচছজঝঞটঠডঢণতথদধনপফবভমযরলশষসহ়ঽািীুূৃৄেৈোৌ্ৎৗড়ঢ়য়ৠৡৢৣৰৱ৲৳৴৵৶৷৸৹৺৻']+$/, // eslint-disable-line no-misleading-character-class
   eo: /^[ABCĈD-GĜHĤIJĴK-PRSŜTUŬVZ]+$/i,
   'hi-IN': /^[\u0900-\u0961]+[\u0972-\u097F]*$/i,
   'si-LK': /^[\u0D80-\u0DFF]+$/,
@@ -72,10 +72,10 @@ export const alphanumeric = {
   'ko-KR': /^[0-9ㄱ-ㅎㅏ-ㅣ가-힣]*$/,
   'ku-IQ': /^[٠١٢٣٤٥٦٧٨٩0-9ئابپتجچحخدرڕزژسشعغفڤقکگلڵمنوۆھەیێيطؤثآإأكضصةظذ]+$/i,
   'vi-VN': /^[0-9A-ZÀÁẠẢÃÂẦẤẬẨẪĂẰẮẶẲẴĐÈÉẸẺẼÊỀẾỆỂỄÌÍỊỈĨÒÓỌỎÕÔỒỐỘỔỖƠỜỚỢỞỠÙÚỤỦŨƯỪỨỰỬỮỲÝỴỶỸ]+$/i,
-  ar: /^[٠١٢٣٤٥٦٧٨٩0-9ءآأؤإئابةتثجحخدذرزسشصضطظعغفقكلمنهوىيًٌٍَُِّْٰ]+$/,
+  ar: /^[٠١٢٣٤٥٦٧٨٩0-9ءآأؤإئابةتثجحخدذرزسشصضطظعغفقكلمنهوىيًٌٍَُِّْٰ]+$/, // eslint-disable-line no-misleading-character-class
   he: /^[0-9א-ת]+$/,
   fa: /^['0-9آاءأؤئبپتثجچحخدذرزژسشصضطظعغفقکگلمنوهةی۱۲۳۴۵۶۷۸۹۰']+$/i,
-  bn: /^['ঀঁংঃঅআইঈউঊঋঌএঐওঔকখগঘঙচছজঝঞটঠডঢণতথদধনপফবভমযরলশষসহ়ঽািীুূৃৄেৈোৌ্ৎৗড়ঢ়য়ৠৡৢৣ০১২৩৪৫৬৭৮৯ৰৱ৲৳৴৵৶৷৸৹৺৻']+$/,
+  bn: /^['ঀঁংঃঅআইঈউঊঋঌএঐওঔকখগঘঙচছজঝঞটঠডঢণতথদধনপফবভমযরলশষসহ়ঽািীুূৃৄেৈোৌ্ৎৗড়ঢ়য়ৠৡৢৣ০১২৩৪৫৬৭৮৯ৰৱ৲৳৴৵৶৷৸৹৺৻']+$/, // eslint-disable-line no-misleading-character-class
   eo: /^[0-9ABCĈD-GĜHĤIJĴK-PRSŜTUŬVZ]+$/i,
   'hi-IN': /^[\u0900-\u0963]+[\u0966-\u097F]*$/i,
   'si-LK': /^[0-9\u0D80-\u0DFF]+$/,
@@ -86,7 +86,6 @@ export const decimal = {
   ar: '٫',
 };
 
-
 export const englishLocales = ['AU', 'GB', 'HK', 'IN', 'NZ', 'ZA', 'ZM'];
 
 for (let locale, i = 0; i < englishLocales.length; i++) {

src/lib/isAscii.js

@@ -1,8 +1,6 @@
 import assertString from './util/assertString';
 
-/* eslint-disable no-control-regex */
-const ascii = /^[\x00-\x7F]+$/;
-/* eslint-enable no-control-regex */
+const ascii = /^[\x00-\x7F]+$/; // eslint-disable-line no-control-regex
 
 export default function isAscii(str) {
   assertString(str);

src/lib/isByteLength.js

@@ -1,6 +1,5 @@
 import assertString from './util/assertString';
 
-/* eslint-disable prefer-rest-params */
 export default function isByteLength(str, options) {
   assertString(str);
   let min;
@@ -9,8 +8,8 @@ export default function isByteLength(str, options) {
     min = options.min || 0;
     max = options.max;
   } else { // backwards compatibility: isByteLength(str, min [, max])
-    min = arguments[1];
-    max = arguments[2];
+    min = arguments[1]; // eslint-disable-line prefer-rest-params
+    max = arguments[2]; // eslint-disable-line prefer-rest-params
   }
   const len = encodeURI(str).split(/%..|./).length - 1;
   return len >= min && (typeof max === 'undefined' || len <= max);

src/lib/isCreditCard.js

@@ -34,7 +34,7 @@ export default function isCreditCard(card, options = {}) {
   } else if (provider && !(provider.toLowerCase() in cards)) {
     /* specific provider not in the list */
     throw new Error(`${provider} is not a valid credit card provider.`);
-  } else if (!allCards.some(cardProvider => cardProvider.test(sanitized))) {
+  } else if (!allCards.some((cardProvider) => cardProvider.test(sanitized))) {
     // no specific provider
     return false;
   }

src/lib/isCurrency.js

@@ -5,15 +5,14 @@ function currencyRegex(options) {
   let decimal_digits = `\\d{${options.digits_after_decimal[0]}}`;
   options.digits_after_decimal.forEach((digit, index) => { if (index !== 0) decimal_digits = `${decimal_digits}|\\d{${digit}}`; });
 
-  const symbol =
-    `(${options.symbol.replace(/\W/, m => `\\${m}`)})${(options.require_symbol ? '' : '?')}`,
-    negative = '-?',
-    whole_dollar_amount_without_sep = '[1-9]\\d*',
-    whole_dollar_amount_with_sep = `[1-9]\\d{0,2}(\\${options.thousands_separator}\\d{3})*`,
-    valid_whole_dollar_amounts = [
-      '0', whole_dollar_amount_without_sep, whole_dollar_amount_with_sep],
-    whole_dollar_amount = `(${valid_whole_dollar_amounts.join('|')})?`,
-    decimal_amount = `(\\${options.decimal_separator}(${decimal_digits}))${options.require_decimal ? '' : '?'}`;
+  const symbol = `(${options.symbol.replace(/\W/, (m) => `\\${m}`)})${(options.require_symbol ? '' : '?')}`;
+  const negative = '-?';
+  const whole_dollar_amount_without_sep = '[1-9]\\d*';
+  const whole_dollar_amount_with_sep = `[1-9]\\d{0,2}(\\${options.thousands_separator}\\d{3})*`;
+  const valid_whole_dollar_amounts = [
+    '0', whole_dollar_amount_without_sep, whole_dollar_amount_with_sep];
+  const whole_dollar_amount = `(${valid_whole_dollar_amounts.join('|')})?`;
+  const decimal_amount = `(\\${options.decimal_separator}(${decimal_digits}))${options.require_decimal ? '' : '?'}`;
   let pattern = whole_dollar_amount + (options.allow_decimal || options.require_decimal ? decimal_amount : '');
 
   // default is negative sign before symbol, but there are two other options (besides parens)
@@ -53,7 +52,6 @@ function currencyRegex(options) {
   return new RegExp(`^(?!-? )(?=.*\\d)${pattern}$`);
 }
 
-
 const default_currency_options = {
   symbol: '$',
   require_symbol: false,

src/lib/isDataURI.js

@@ -8,7 +8,7 @@ const validData = /^[a-z0-9!\$&'\(\)\*\+,;=\-\._~:@\/\?%\s]*$/i;
 
 export default function isDataURI(str) {
   assertString(str);
-  let data = str.split(',');
+  const data = str.split(',');
   if (data.length < 2) {
     return false;
   }
@@ -23,8 +23,8 @@ export default function isDataURI(str) {
   }
   for (let i = 0; i < attributes.length; i++) {
     if (
-      !(i === attributes.length - 1 && attributes[i].toLowerCase() === 'base64') &&
-      !validAttribute.test(attributes[i])
+      !(i === attributes.length - 1 && attributes[i].toLowerCase() === 'base64')
+      && !validAttribute.test(attributes[i])
     ) {
       return false;
     }

src/lib/isDate.js

@@ -11,8 +11,8 @@ function isValidFormat(format) {
 }
 
 function zip(date, format) {
-  const zippedArr = [],
-    len = Math.max(date.length, format.length);
+  const zippedArr = [];
+  const len = Math.max(date.length, format.length);
 
   for (let i = 0; i < len; i++) {
     zippedArr.push([date[i], format[i]]);
@@ -30,10 +30,10 @@ export default function isDate(input, options) {
   if (typeof input === 'string' && isValidFormat(options.format)) {
     if (options.strictMode && input.length !== options.format.length) return false;
     const formatDelimiter = options.delimiters
-      .find(delimiter => options.format.indexOf(delimiter) !== -1);
+      .find((delimiter) => options.format.indexOf(delimiter) !== -1);
     const dateDelimiter = options.strictMode
       ? formatDelimiter
-      : options.delimiters.find(delimiter => input.indexOf(delimiter) !== -1);
+      : options.delimiters.find((delimiter) => input.indexOf(delimiter) !== -1);
     const dateAndFormat = zip(
       input.split(dateDelimiter),
       options.format.toLowerCase().split(formatDelimiter)