fix assertString to throw TypeErrors on objects with custom constructor property

newtondividedbysqm · web-flow · commit ba3c7ae1b2f7 · 2026-03-30T19:48:50.000+02:00
diff --git a/src/lib/util/assertString.js b/src/lib/util/assertString.js
@@ -1,4 +1,4 @@
 export default function assertString(input) {
   if (input === undefined || input === null) throw new TypeError(`Expected a string but received a ${input}`);
-  if (input.constructor.name !== 'String') throw new TypeError(`Expected a string but received a ${input.constructor.name}`);
+  if (typeof input !== 'string' && !(input instanceof String)) throw new TypeError(`Expected a string but received a ${input?.constructor?.name ?? typeof input}`)
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`export default function assertString(input) {`
`2`	`2`	if (input === undefined \|\| input === null) throw new TypeError(`Expected a string but received a ${input}`);
`3`		- if (input.constructor.name !== 'String') throw new TypeError(`Expected a string but received a ${input.constructor.name}`);
	`3`	+ if (typeof input !== 'string' && !(input instanceof String)) throw new TypeError(`Expected a string but received a ${input?.constructor?.name ?? typeof input}`)
`4`	`4`	`}`