fix(isURL): block credentials in protocol-relative URLs (+ regression tests)#2613
Closed
jordyloeuille wants to merge 1 commit intovalidatorjs:masterfrom
Closed
fix(isURL): block credentials in protocol-relative URLs (+ regression tests)#2613jordyloeuille wants to merge 1 commit intovalidatorjs:masterfrom
jordyloeuille wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2613 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2536 2541 +5
Branches 642 644 +2
=========================================
+ Hits 2536 2541 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
validator.js has a URL validation bypass vulnerability in its isURL function - GHSA-9965-vmph-33xx |
Member
|
Why's the comment (partially) in Dutch? Looks AI generated. Either way, the idea is that #2608 will be reviewed and eventually merged. Feel free to review that one and suggest improvements from this PR if they are useful. Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch hardens isURL for protocol-relative inputs by rejecting credentials in the authority
(e.g.
//user:pass@example.com) whenallow_protocol_relative_urlsis true.https:example.com/http:example.comhttps://example.comandhttp://example.com/path?x=1#yNo API changes; minimal code change in the
//branch. All tests and lint pass locally.