Skip to content

Fix for bug where Recommended section would re-appear#4938

Open
antoniu200 wants to merge 2 commits intovalinet:masterfrom
antoniu200:EP_Pull
Open

Fix for bug where Recommended section would re-appear#4938
antoniu200 wants to merge 2 commits intovalinet:masterfrom
antoniu200:EP_Pull

Conversation

@antoniu200
Copy link
Copy Markdown

Hello,

Various interactions inside the Start Menu trigger OnSettingChanged(), which in turn calls UpdatePinnedListHeight(), which causes the reported problem (#4783 #4752 #4509 #4409 #4315 #4072 #3788 #3748 #3313 #2754 #2622 #2580 #2212).
I've hooked OnSettingChanged(), to mark that it has been called, forwarded to the real function, and, when UpdatePinnedListHeight() is called afterwards (also hooked), we return from the hooked function, if the DisableRecommended flag is enabled.

Adjusting Pinned List Height from Settings still works as expected.

Builds that do not have this OnSettingChanged logic will not be affected, functionally. At most, the user might see a notification that only "Some symbols were downloaded".

Fix has been tested and working on:

22621.1485 (to see what it does when functions don't exist)

22631.6936

26100.1
26100.1742
26100.2605
26100.4946
26100.6899
26100.8246

26200.8037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant