Fix unused variable warnings in rdma.c with NDEBUG#312
Open
bjosv wants to merge 2 commits into
Open
Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
@pizhenwei Are you ok with this change? |
pizhenwei
reviewed
May 15, 2026
|
|
||
| static int valkeyRdmaWaitConn(valkeyContext *c, long timeout) { | ||
| long now, end; | ||
| RdmaContext *ctx = c->privctx; |
Contributor
There was a problem hiding this comment.
Declaring a temporary variable in a separate line, casting it from a private type pointer, and then accessing it — to me, the original style is more readable. However, I don’t object to the current style either.
Otherwise, LGTM.
pizhenwei
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary local variables
ctxandeventinvalkeyRdmaWaitConnthat only existed to make anassert()more readable. When built with-DNDEBUG -Werror, the assert is removed and both variables become unused, causing a build failure.Also enable Release build types in the RDMA CI job so that NDEBUG is defined and this class of issue is caught going forward.
Fixes #311