Fix documentation snippets#315
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Collaborator
|
Good findings, please update the commit with a DCO, see CONTRIBUTING.md |
Author
|
@bjosv I will check later today. |
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
79dd72e to
06bedbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valkeyClusterOptionsdesignated-initializer examples incluster.mdgencommands.pylink incluster.mdvalkeyCommandArgvsnippet typo instandalone.mdvalkeyReplywording typo instandalone.mdWhy
Several documentation snippets were not copy-pasteable as written. The cluster docs used semicolons inside C designated initializers, one async example missed the closing
;after the initializer, thegencommands.pylink pointed at the wrong directory, andstandalone.mdhad two small typos.Validation
scripts/gencommands.pyexistsdocs/cluster.mdanddocs/standalone.md