Skip to content

Benchmark: removed push trigger and default push variables #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liorsve merged 1 commit into from
Feb 18, 2026
Merged

Benchmark: removed push trigger and default push variables #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 6 additions & 26 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,7 @@ on:
type: string
default: ""

push:
branches:
- add-benchmark-ci

env:
DEFAULT_PRIMARY_DRIVER: "spring-data-valkey"
DEFAULT_SECONDARY_DRIVER: "valkey-glide"
DEFAULT_WORKLOAD: "example-workload"
DEFAULT_PRIMARY_VERSION: ""
DEFAULT_SECONDARY_VERSION: ""
DEFAULT_JOB_ID_PREFIX: ""
RESP_BENCH_REPO: "https://github.com/ikolomi/resp-bench.git"

jobs:
Expand Down Expand Up @@ -89,22 +79,12 @@ jobs:
- name: Resolve inputs
id: inputs
run: |
# TODO: this is for testing only. Remove once possible
if [ "${{ github.event_name }}" = "push" ]; then
PRIMARY_DRIVER="${{ env.DEFAULT_PRIMARY_DRIVER }}"
SECONDARY_DRIVER="${{ env.DEFAULT_SECONDARY_DRIVER }}"
WORKLOAD="${{ env.DEFAULT_WORKLOAD }}"
PRIMARY_VERSION="${{ env.DEFAULT_PRIMARY_VERSION }}"
SECONDARY_VERSION="${{ env.DEFAULT_SECONDARY_VERSION }}"
JOB_ID_PREFIX="${{ env.DEFAULT_JOB_ID_PREFIX }}"
else
PRIMARY_DRIVER="${{ github.event.inputs.primary_driver }}"
SECONDARY_DRIVER="${{ github.event.inputs.secondary_driver }}"
WORKLOAD="${{ github.event.inputs.workload }}"
PRIMARY_VERSION="${{ github.event.inputs.primary_version }}"
SECONDARY_VERSION="${{ github.event.inputs.secondary_version }}"
JOB_ID_PREFIX="${{ github.event.inputs.job_id_prefix }}"
fi
PRIMARY_DRIVER="${{ github.event.inputs.primary_driver }}"
SECONDARY_DRIVER="${{ github.event.inputs.secondary_driver }}"
WORKLOAD="${{ github.event.inputs.workload }}"
PRIMARY_VERSION="${{ github.event.inputs.primary_version }}"
SECONDARY_VERSION="${{ github.event.inputs.secondary_version }}"
JOB_ID_PREFIX="${{ github.event.inputs.job_id_prefix }}"

echo "primary_driver=$PRIMARY_DRIVER" >> $GITHUB_OUTPUT
echo "secondary_driver=$SECONDARY_DRIVER" >> $GITHUB_OUTPUT
Expand Down