Added libbacktrace support for alpine

[hanxizh9910]

libbacktrace is not available as an Alpine package, so this PR builds it from source during the Alpine Docker build and links it into the final image

• Build libbacktrace from source in the Alpine build stage
• Pass USE_LIBBACKTRACE=yes to the valkey make invocation on Alpine
• Copy libbacktrace.so into the runtime image
  Related PR: Add libbacktrace fallback for stack traces on musl/Alpine valkey#3581

[rainsupreme]

I don't know too much about docker stuff, but I left a few comments/questions 😅

[rainsupreme]

We should pick a specific commit of libbacktrace to make this more secure against dependency injection. I think we should also add a comment with the commit date to give us an idea of whether it needs to be updated.

[rainsupreme]

Also, by any chance is this run in an isolated environment by Docker or someone else? The git clone network access would fail in that case. I don't know if this is actually an issue though

[hanxizh9910]

Also, by any chance is this run in an isolated environment by Docker or someone else? The git clone network access would fail in that case. I don't know if this is actually an issue though

Hi, thank you for your question! Docker builds have network access during build time. The existing Dockerfile already uses ADD to download the valkey tarball from GitHub, so git clone works the same way.

[rainsupreme]

I'm unfamiliar with our docker releases so please excuse my ignorance, but does this mean libbacktrace gets built on other platforms even when it is not used? (Alternatively, would we like to add libbacktrace to all our docker releases? I think that would be valuable.)

The {{ if env.variant == "alpine" then ( -}} check below suggests that this is run on alpine and other platforms, but I'm not sure which those are.

[hanxizh9910]

Hi, the libbacktrace build is inside the Alpine-only block, so it doesn't run on Debian.
Enabling libbacktrace on Debian is a good idea, it would give us more information. If the team thinks this is great, I can definitely do it in a follow-up PR.

[roshkhatri]

you will also have to run apply_templates.sh

[roshkhatri]

you can directly clone at that commit hash above - Sorry I am wrong inthis
We should hard reset to the commit, libbacktrace does not have a release or a branch or a tag

[rainsupreme]

It's looking improved 🙂 Seems like there are failing workflows though? Did you test this after your recent update? (if so I didn't catch it)

[hanxizh9910]

It's looking improved 🙂 Seems like there are failing workflows though? Did you test this after your recent update? (if so I didn't catch it)

Hi, the CI failure is expected, the container PR depends on valkey#3581 (valkey-io/valkey#3581) being merged first: the unstable Alpine build fails because it downloads from valkey-io/valkey:unstable, which doesn't have the musl/Alpine backtrace support yet. Once #3581 merges, this will pass on the next CI run. The stable version builds (7.2, 8.0, 8.1, 9.0) fail because those are fixed release tarballs that were cut before the fix existed