Skip to content

Added libbacktrace support for alpine #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanxizh9910 wants to merge 3 commits into
base: mainline
Choose a base branch
from
Open

Added libbacktrace support for alpine #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45fb81c
Added libbacktrace support for alpine
hanxizh9910 Apr 28, 2026
2837c19
Pin to a specific commit
hanxizh9910 May 5, 2026
59232dc
Use full clone + git reset --hard for libbacktrace to fix pinned comm…
hanxizh9910 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion 7.2/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 17 additions & 1 deletion 8.0/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 17 additions & 1 deletion 8.1/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 17 additions & 1 deletion 9.0/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion 9.1/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 19 additions & 1 deletion Dockerfile.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,21 @@ RUN set -eux; \
make \
musl-dev \
openssl-dev \
git \
autoconf \
automake \
libtool \
; \
# build libbacktrace from source (not available as Alpine package)
Copy link
Copy Markdown

@rainsupreme rainsupreme Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with our docker releases so please excuse my ignorance, but does this mean libbacktrace gets built on other platforms even when it is not used? (Alternatively, would we like to add libbacktrace to all our docker releases? I think that would be valuable.)

The {{ if env.variant == "alpine" then ( -}} check below suggests that this is run on alpine and other platforms, but I'm not sure which those are.

Copy link
Copy Markdown
Contributor Author

@hanxizh9910 hanxizh9910 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the libbacktrace build is inside the Alpine-only block, so it doesn't run on Debian.
Enabling libbacktrace on Debian is a good idea, it would give us more information. If the team thinks this is great, I can definitely do it in a follow-up PR.

# pinned to commit 96664e69b1ecdb76e824be1d9e8f475b76dd08cf (2026-05-03)
git clone https://github.com/ianlancetaylor/libbacktrace.git /tmp/libbacktrace; \
cd /tmp/libbacktrace; \
git reset --hard 96664e69b1ecdb76e824be1d9e8f475b76dd08cf; \
./configure --prefix=/usr; \
make -j "$(nproc)"; \
make install; \
cd /; \
rm -rf /tmp/libbacktrace; \
{{ ) else ( -}}
apt-get update; \
apt-get install -y --no-install-recommends \
Expand Down Expand Up @@ -92,7 +106,7 @@ RUN set -eux; \
export BUILD_TLS=yes; \
{{ ) end -}}
{{ if env.variant == "alpine" then ( -}}
\
export USE_LIBBACKTRACE=yes; \
{{ ) else ( -}}
export USE_SYSTEMD=yes; \
{{ ) end -}}
Expand Down Expand Up @@ -174,6 +188,10 @@ RUN set -eux; \

# Install valkey built earlier
COPY --from=build /usr/local /usr/local
{{ if env.variant == "alpine" then ( -}}
# copy libbacktrace for backtrace support on musl
COPY --from=build /usr/lib/libbacktrace.so* /usr/lib/
{{ ) else "" end -}}
RUN mkdir /data && \
chown valkey:valkey /data && \
chmod 1777 /data && \
Expand Down
18 changes: 17 additions & 1 deletion unstable/alpine/Dockerfile
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading