Add context manager support to clients#5693
Merged
Merged
Conversation
Signed-off-by: redoubts <Redoubts@users.noreply.github.com>
Signed-off-by: redoubts <Redoubts@users.noreply.github.com>
xShinnRyuu
reviewed
Apr 17, 2026
Signed-off-by: redoubts <Redoubts@users.noreply.github.com>
xShinnRyuu
approved these changes
Apr 20, 2026
Aryex
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valkey-glide should allow for pythonic resource management, by supporting context managers. This adds that.
Issue link
Closes #5623
Features / Behaviour Changes
Adds enter/exit methods for sync + async clients
Limitations
Leaves the async
closemethod, thoacloseis preferred for async resources. But this allows the change to be non-breakingTesting
python dev.py test --args -k test_context_manager