Node.js: Add RESET command support#5945
Open
affonsov wants to merge 4 commits into
Open
Conversation
ec17782 to
77503a1
Compare
Collaborator
|
Changelog? |
alexr-bq
approved these changes
May 19, 2026
xShinnRyuu
approved these changes
May 20, 2026
Collaborator
xShinnRyuu
left a comment
There was a problem hiding this comment.
Everything looks good to me besides adding CHANGELOG entry. Please update change log before merging
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
6803aca to
18db692
Compare
Signed-off-by: affonsov <67347924+affonsov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the
RESETcommand to the Node.js client.RESETresets the connection state.Issue link
This Pull Request is linked to issue: Implement RESET command for Python, Node.js, Go, and Java clients
Closes #5942
Features / Behaviour Changes
createReset()factory added toCommands.tsreset()added toBaseClient, available on bothGlideClientandGlideClusterClientreset()added toBaseBatchImplementation
RequestType.Resetwith no arguments; returns"RESET"on successLimitations
None.
Testing
GlideClient.test.tsandGlideClusterClient.test.tsChecklist