fix: support secretKeyRef in metrics exporter extraEnvs#167
Open
kkonaparthi1 wants to merge 1 commit into
Open
fix: support secretKeyRef in metrics exporter extraEnvs#167kkonaparthi1 wants to merge 1 commit into
kkonaparthi1 wants to merge 1 commit into
Conversation
Update the extraEnvs template in statefulset.yaml and deploy_valkey.yaml to check the value type using kindIs. Plain string values continue to render as value: while map/object values render as valueFrom: blocks. This enables passing credentials securely via Kubernetes secrets (e.g. secretKeyRef) to the metrics exporter sidecar, which was previously impossible because the template hardcoded value: for all entries. Backwards compatible — existing plain string extraEnvs continue to work unchanged. Fixes valkey-io#151 Signed-off-by: Karthik Konaparthi <konapk@amazon.com>
Collaborator
|
Hi @kkonaparthi1, the REDIS_PASSWORD use case was fixed on #141 and released on chart 0.94. Is there any additional use case for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151
Summary
Update the
extraEnvstemplate to support Kubernetes secret references (secretKeyRef) in addition to plain string values.Changes
statefulset.yaml— check value type withkindIs "string", rendervalue:for strings orvalueFrom:for objectsdeploy_valkey.yaml— same fixvalues.yaml— updated example comments showing both plain and secret reference usageBackwards Compatible
Existing plain string
extraEnvsvalues continue to work unchanged. Only map/object values are now rendered asvalueFrom:blocks.Example