Skip to content

Commit f2f4e5d

Browse files
Run ASan Tests on run-extra-tests label (#3512)
It's important to enabled ASAN on run-extra-tests label so we can catch some of the bugs in the PRs before they are merged into unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
1 parent cea9354 commit f2f4e5d

1 file changed

Lines changed: 30 additions & 5 deletions

File tree

.github/workflows/daily.yml

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -945,7 +945,12 @@ jobs:
945945
if: |
946946
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
947947
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
948-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable' && github.event.action != 'labeled')) &&
948+
(github.event_name == 'pull_request' &&
949+
(github.event.pull_request.base.ref != 'unstable' ||
950+
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
951+
(github.event.action != 'labeled' ||
952+
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
953+
)) &&
949954
!contains(github.event.inputs.skipjobs, 'sanitizer')
950955
timeout-minutes: 1440
951956
strategy:
@@ -1008,7 +1013,12 @@ jobs:
10081013
if: |
10091014
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
10101015
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
1011-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable' && github.event.action != 'labeled')) &&
1016+
(github.event_name == 'pull_request' &&
1017+
(github.event.pull_request.base.ref != 'unstable' ||
1018+
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
1019+
(github.event.action != 'labeled' ||
1020+
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
1021+
)) &&
10121022
!contains(github.event.inputs.skipjobs, 'sanitizer') &&
10131023
!contains(github.event.inputs.skiptests, 'large-memory')
10141024
timeout-minutes: 1440
@@ -1080,7 +1090,12 @@ jobs:
10801090
if: |
10811091
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
10821092
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
1083-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable' && github.event.action != 'labeled')) &&
1093+
(github.event_name == 'pull_request' &&
1094+
(github.event.pull_request.base.ref != 'unstable' ||
1095+
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
1096+
(github.event.action != 'labeled' ||
1097+
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
1098+
)) &&
10841099
!contains(github.event.inputs.skipjobs, 'sanitizer')
10851100
timeout-minutes: 1440
10861101
strategy:
@@ -1143,7 +1158,12 @@ jobs:
11431158
if: |
11441159
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
11451160
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
1146-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable' && github.event.action != 'labeled')) &&
1161+
(github.event_name == 'pull_request' &&
1162+
(github.event.pull_request.base.ref != 'unstable' ||
1163+
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
1164+
(github.event.action != 'labeled' ||
1165+
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
1166+
)) &&
11471167
!contains(github.event.inputs.skipjobs, 'sanitizer') &&
11481168
!contains(github.event.inputs.skiptests, 'large-memory')
11491169
timeout-minutes: 1440
@@ -1215,7 +1235,12 @@ jobs:
12151235
if: |
12161236
(github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch' ||
12171237
(github.event_name == 'schedule' && github.repository == 'valkey-io/valkey') ||
1218-
(github.event_name == 'pull_request' && github.event.pull_request.base.ref != 'unstable' && github.event.action != 'labeled')) &&
1238+
(github.event_name == 'pull_request' &&
1239+
(github.event.pull_request.base.ref != 'unstable' ||
1240+
contains(github.event.pull_request.labels.*.name, 'run-extra-tests')) &&
1241+
(github.event.action != 'labeled' ||
1242+
(github.event.pull_request.base.ref == 'unstable' && github.event.label.name == 'run-extra-tests'))
1243+
)) &&
12191244
!contains(github.event.inputs.skipjobs, 'sanitizer')
12201245
timeout-minutes: 1440
12211246
strategy:

0 commit comments

Comments
 (0)