Skip to content

fix(typeahead): accessibility fixes#6791

Merged
lexasq merged 5 commits into
valor-software:developmentfrom
YusefOuda:typeahead-accessibility-fix
Jun 12, 2026
Merged

fix(typeahead): accessibility fixes#6791
lexasq merged 5 commits into
valor-software:developmentfrom
YusefOuda:typeahead-accessibility-fix

Conversation

@YusefOuda

@YusefOuda YusefOuda commented Jan 30, 2026

Copy link
Copy Markdown
Contributor
  • Adds role=combobox and sets aria-controls instead of aria-owns on typeahead.
  • Ensure activeChangeEvent is fired when active item changes by using setter

Fixes #6468, #6647

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

- Adds role=combobox and sets aria-controls instead of aria-owns on typeahead.
- Ensure `activeChangeEvent` is fired when active item changes by using setter

Fixes valor-software#6468, valor-software#6647
@coliff

coliff commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Great PR! Hope to see this merged.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.78%. Comparing base (e77c928) to head (874fa16).
⚠️ Report is 33 commits behind head on development.

Files with missing lines Patch % Lines
src/typeahead/typeahead-container.component.ts 81.25% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6791      +/-   ##
===============================================
+ Coverage        76.60%   77.78%   +1.18%     
===============================================
  Files              317      318       +1     
  Lines            10748    11094     +346     
  Branches          2866     3081     +215     
===============================================
+ Hits              8233     8629     +396     
+ Misses            2514     2463      -51     
- Partials             1        2       +1     
Files with missing lines Coverage Δ
src/typeahead/typeahead.directive.ts 86.52% <100.00%> (+1.45%) ⬆️
src/typeahead/typeahead-container.component.ts 83.91% <81.25%> (+6.50%) ⬆️

... and 77 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7fe4b...874fa16. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lexasq lexasq merged commit 75cef79 into valor-software:development Jun 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aria-activedescendant attribute is not added when active item changes in typeahead

3 participants