refactor(component-loader): replace ComponentFactoryResolver with createComponent#6813
Open
DerekLiang wants to merge 3 commits into
Open
Conversation
…ateComponent ComponentFactoryResolver was deprecated in Angular 13 and removed in Angular 17+. Replace all usages with the modern createComponent() API and EnvironmentInjector. Affects: Modal, Tooltip, Popover, Typeahead, Dropdown, Datepicker, and Daterangepicker — all components that use ComponentLoaderFactory to dynamically render overlay/popup content. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DerekLiang
force-pushed
the
dl/2026-05/ComponentFactoryResolver-removal
branch
from
c858183 to
fb7b08f
Compare
Contributor
Author
|
@lexasq could you please take a look and provide feedback? thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComponentFactoryResolverBlocks upgrade to Angular 22rc1.ComponentFactoryResolver(deprecated in Angular 13, removed in Angular 17+) fromComponentLoaderFactoryandComponentLoaderComponentFactory.create()calls with the moderncreateComponent()function from@angular/coreEnvironmentInjectorin place ofComponentFactoryResolverAffected components
All components that use
ComponentLoaderFactoryto dynamically render overlay/popup content are affected by this change:src/modal/modal.directive.ts,src/modal/bs-modal.service.tssrc/tooltip/tooltip.directive.tssrc/popover/popover.directive.tssrc/typeahead/typeahead.directive.tssrc/dropdown/bs-dropdown.directive.tssrc/datepicker/bs-datepicker.component.ts,src/datepicker/bs-daterangepicker.component.tssrc/datepicker/bs-datepicker-inline.component.ts,src/datepicker/bs-daterangepicker-inline.component.tsTest plan
npm test)🤖 Generated with Claude Code