Avoid large allocation in map and use progressive one in array#120
Open
JamalK wants to merge 2 commits intovalpackett:masterfrom
Open
Avoid large allocation in map and use progressive one in array#120JamalK wants to merge 2 commits intovalpackett:masterfrom
JamalK wants to merge 2 commits intovalpackett:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take to fix this crasher #118
Description
When using (0..<n).map we are forcing the large allocation to happen in one-shot which caused the crash
Fix
Append to an array that grows its allocation as the input grows.
Testing
Unit test from #118
Validated that all existing tests still pass.