fix: implement superEncoder methods for Codable class hierarchies#123
Open
hamchapman wants to merge 1 commit intohc/fix-unsafe-error-handling-and-allocation-crashesfrom
Conversation
Previously, `superEncoder()` and `superEncoder(forKey:)` methods in both
`KeyedEncodingContainer` and `UnkeyedEncodingContainer` would crash with
`fatalError("Unimplemented")`.
This commit implements these methods to properly support Swift class inheritance
with Codable, allowing subclasses to encode their superclass properties into
nested containers.
**Changes:**
- `KeyedEncodingContainer.superEncoder()`: Creates encoder under "super" key
- `KeyedEncodingContainer.superEncoder(forKey:)`: Creates encoder under custom key
- `UnkeyedEncodingContainer.superEncoder()`: Appends encoder as array element
- Make `_CBOREncoder` conform to `CBOREncodingContainer` protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
superEncoder()andsuperEncoder(forKey:)methods in bothKeyedEncodingContainerandUnkeyedEncodingContainerwould crash withfatalError("Unimplemented").This commit implements these methods to properly support Swift class inheritance with Codable, allowing subclasses to encode their superclass properties into nested containers.
Changes:
KeyedEncodingContainer.superEncoder(): Creates encoder under "super" keyKeyedEncodingContainer.superEncoder(forKey:): Creates encoder under custom keyUnkeyedEncodingContainer.superEncoder(): Appends encoder as array element_CBOREncoderconform toCBOREncodingContainerprotocol