fix: typo in CBOROptions parameter: shouldShortMapKeys → shouldSortMapKeys#125
Open
hamchapman wants to merge 1 commit intomasterfrom
Open
fix: typo in CBOROptions parameter: shouldShortMapKeys → shouldSortMapKeys#125hamchapman wants to merge 1 commit intomasterfrom
CBOROptions parameter: shouldShortMapKeys → shouldSortMapKeys#125hamchapman wants to merge 1 commit intomasterfrom
Conversation
…ortMapKeys` The parameter name in `CBOROptions.init()` was incorrectly spelled as `shouldShortMapKeys` when it should be `shouldSortMapKeys` to match the property name and convey the correct meaning (sorting keys, not shortening them).
hamchapman
force-pushed
the
hc/fix-typo-in-shouldsortmapkeys-option
branch
from
e4cbb36 to
d572f48
Compare
hamchapman
changed the base branch from
hc/fix-maximum-depth-not-enforced-dos-vulnerability
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter name in
CBOROptions.init()was incorrectly spelled asshouldShortMapKeyswhen it should beshouldSortMapKeysto match the property name and convey the correct meaning (sorting keys, not shortening them).