Fix options page#93
Open
PSMJonas wants to merge 1 commit into
Open
Conversation
This was referenced Jun 17, 2024
|
This DOES fix the issue! Nice call.- |
|
The resolver is executed on all queries, maybe we could keep the function Something like : $type = $source['type'] ?? null;
$class_name = isset($source['node']) ? get_class($source['node']) : null;
return $type === 'options_page' || $class_name == \WPGraphQL\Acf\Model\AcfOptionsPage::class; |
|
I've just checked the snippet above, it seems to work indeed. However, I am not familiar enough with the plugin to implement this and understand the consequences. Can someone with more experience verify this and merge this so the issue can be solved? |
|
Can this fix be implemented please? So we can stop using a mirror plugin with just this fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of the content based on the selected language did not work because the
typeattribute was not present:$typeis alwaysnull.