⏫ Upgrading to react-native 0.66.0 🔥 0️.6️6️.0️

Author: stevegalili

.gitignore

@@ -23,11 +23,11 @@ DerivedData
 
 # Android/IntelliJ
 #
-build/
 .idea
 .gradle
 local.properties
 *.iml
+*.hprof
 
 # Visual Studio Code
 #

__mocks__/react-native-gesture-handler.ts

@@ -0,0 +1,3 @@
+import {View} from 'react-native'
+
+export default View

__mocks__/react-native-video.ts

@@ -1,4 +1,5 @@
 import 'react-native'
+// @ts-ignore
 import React from 'react'
 import {
   fireEvent,
@@ -33,10 +34,9 @@ it('scrolls to top and refreshes all items', async () => {
 
   getByText(/pizza/i)
   expect(() => getByText(/the impossible burger/i)).toThrow(
-    /no instances found/i,
+    'Unable to find an element with text: /the impossible burger/i',
   ) //intially not shown
   fireEvent.scroll(getByTestId('flat-list'), eventData)
   await waitForElementToBeRemoved(() => getByText(/loading more dishes/i))
   await waitFor(() => expect(getByText(/the impossible burger/i)))
-  //2 awaits results in a warning at the moment see https://github.com/callstack/react-native-testing-library/issues/379
 })

__tests__/FlatList.test.tsx

@@ -2,6 +2,7 @@ import React from 'react'
 import {fireEvent, render, waitFor} from '@testing-library/react-native'
 import App from '../src/components/App'
 import {expect, it, jest} from '@jest/globals'
+
 //mocking async storage module
 const mockedSetItem = jest.fn()
 jest.mock('@react-native-community/async-storage', () => ({

__tests__/Home.test.tsx

@@ -1,4 +1,5 @@
 import 'react-native'
+// @ts-ignore
 import React from 'react'
 import {fireEvent, render, waitFor} from '@testing-library/react-native'
 import {expect, it} from '@jest/globals'
@@ -13,13 +14,17 @@ jest.mock('react-native/Libraries/Modal/Modal', () => {
 })
 
 it('renders modal screen correctly', async () => {
-  const {getByText, debug} = render(<ModalScreen />)
+  const {getByText} = render(<ModalScreen />)
 
-  expect(() => getByText(/hello world/i)).toThrow(/no instances found/i) //modal is initially closed
+  expect(() => getByText(/hello world/i)).toThrow(
+    'Unable to find an element with text: /hello world/i',
+  ) //modal is initially closed
 
   fireEvent.press(getByText(/show modal/i))
   await waitFor(() => getByText(/hello world/i)) //modal is now visible
 
   fireEvent.press(getByText(/hide modal/i))
-  expect(() => getByText(/hide modal/i)).toThrow(/no instances found/i) //modal is closed again
+  expect(() => getByText(/hide modal/i)).toThrow(
+    'Unable to find an element with text: /hide modal/i',
+  ) //modal is closed again
 })

__tests__/Modal.test.tsx

@@ -4,15 +4,12 @@ import {fireEvent, render} from '@testing-library/react-native'
 import Video from '../src/components/Video'
 import {StatusBar} from 'react-native'
 
+// 'react-native-video' is being mocked in /__mocks__/react-native-video.ts
+
 const navigationMock = {
   setOptions: jest.fn(),
 }
 
-jest.mock('react-native-video', () => {
-  const mockComponent = require('react-native/jest/mockComponent')
-  return mockComponent('react-native-video')
-})
-
 it('renders/navigates throughout app screens', async () => {
   const {getByText, getByA11yLabel} = render(
     <Video navigation={navigationMock} />,

__tests__/Video.test.tsx

@@ -126,13 +126,9 @@ def enableHermes = project.ext.react.get("enableHermes", false);
 def nativeArchitectures = project.getProperties().get("reactNativeDebugArchitectures")
 
 android {
+    ndkVersion rootProject.ext.ndkVersion
     compileSdkVersion rootProject.ext.compileSdkVersion
 
-    compileOptions {
-        sourceCompatibility JavaVersion.VERSION_1_8
-        targetCompatibility JavaVersion.VERSION_1_8
-    }
-
     defaultConfig {
         applicationId "com.testingrnapps"
         minSdkVersion rootProject.ext.minSdkVersion
@@ -189,8 +185,7 @@ android {
             def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
             def abi = output.getFilter(OutputFile.ABI)
             if (abi != null) {  // null for the universal-debug, universal-release variants
-                output.versionCodeOverride =
-                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
+                output.versionCodeOverride = defaultConfig.versionCode * 1000 + versionCodes.get(abi)
             }
 
         }
@@ -229,7 +224,7 @@ dependencies {
 // Run this once to be able to run the application with BUCK
 // puts all compile dependencies into folder libs for BUCK to use
 task copyDownloadableDepsToLibs(type: Copy) {
-    from configurations.compile
+    from configurations.implementation
     into 'libs'
 }
 

android/app/build.gradle

@@ -1,8 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools">
+          xmlns:tools="http://schemas.android.com/tools">
 
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
-
-    <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" />
+    <application
+            android:usesCleartextTraffic="true"
+            tools:targetApi="28"
+            tools:ignore="GoogleAppIndexingWarning">
+        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity"/>
+    </application>
 </manifest>

android/app/src/debug/AndroidManifest.xml

@@ -21,7 +21,6 @@
             <category android:name="android.intent.category.LAUNCHER" />
         </intent-filter>
       </activity>
-      <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
     </application>
 
 </manifest>