fix: waive inherited schema health debt

Author: tnunamak

.github/workflows/schema-health-check.yml

@@ -51,17 +51,24 @@ jobs:
               GW_ERRORS=$(jq -r '.summary.gatewayErrors' report.json)
               META_DRIFT=$(jq -r '.summary.metadataDrift' report.json)
               ORPHANS=$(jq -r '.summary.orphanedSchemas' report.json)
+              BLOCKING_MISSING_GW=$(jq -r '.summary.blockingMissingGateway // 0' report.json)
+              INHERITED_MISSING_GW=$(jq -r '.summary.inheritedMissingGateway // 0' report.json)
 
               ISSUES=$((MISSING_FILE + MISSING_GW + GW_ERRORS + META_DRIFT + ORPHANS))
+              BLOCKING_ISSUES=$((MISSING_FILE + BLOCKING_MISSING_GW + GW_ERRORS + META_DRIFT + ORPHANS))
 
-              if [ "$ISSUES" = "0" ]; then
+              if [ "$BLOCKING_ISSUES" = "0" ] && [ "$ISSUES" = "0" ]; then
                 echo "## Schema Health Check — All Clear"
                 echo ""
                 echo "All $TOTAL scopes are fully consistent (local schema files + Gateway registration)."
+              elif [ "$BLOCKING_ISSUES" = "0" ]; then
+                echo "## Schema Health Check — Non-blocking inherited issues"
+                echo ""
+                echo "$CONSISTENT/$TOTAL scopes consistent | $INHERITED_MISSING_GW inherited Gateway gap(s) | no new blocking issues in this PR"
               else
-                echo "## Schema Health Check — $ISSUES issue(s) found"
+                echo "## Schema Health Check — $BLOCKING_ISSUES blocking issue(s) found"
                 echo ""
-                echo "$CONSISTENT/$TOTAL scopes consistent | $MISSING_FILE missing schema files | $MISSING_GW not in Gateway | $META_DRIFT metadata drift | $ORPHANS orphaned"
+                echo "$CONSISTENT/$TOTAL scopes consistent | $MISSING_FILE missing schema files | $BLOCKING_MISSING_GW new Gateway gap(s) | $INHERITED_MISSING_GW inherited Gateway gap(s) | $META_DRIFT metadata drift | $ORPHANS orphaned"
                 echo ""
                 echo "<details>"
                 echo "<summary>View issues</summary>"
@@ -112,7 +119,7 @@ jobs:
 
                 echo "</details>"
                 echo ""
-                echo "> These issues should be resolved before connectors can be used by Personal Servers."
+                echo "> New blocking issues must be resolved before connectors can be used by Personal Servers. Inherited Gateway registration debt remains visible but does not fail this PR."
               fi
 
               echo 'COMMENT_EOF'

scripts/schema-health-check.mjs

@@ -366,6 +366,8 @@ const missingSchemaFile = scopeResults.filter((r) => !r.schemaFileExists);
 const missingGateway = scopeResults.filter(
   (r) => r.gatewayStatus === "missing"
 );
+const blockingMissingGateway = missingGateway.filter((r) => r.isNew);
+const inheritedMissingGateway = missingGateway.filter((r) => !r.isNew);
 const gatewayErrors = scopeResults.filter((r) => r.gatewayStatus === "error");
 const metadataDrift = scopeResults.filter(
   (r) => r.metadataMismatches && r.metadataMismatches.length > 0
@@ -377,6 +379,8 @@ const summary = {
   fullyConsistent: fullyConsistent.length,
   missingSchemaFile: missingSchemaFile.length,
   missingGateway: missingGateway.length,
+  blockingMissingGateway: blockingMissingGateway.length,
+  inheritedMissingGateway: inheritedMissingGateway.length,
   gatewayErrors: gatewayErrors.length,
   metadataDrift: metadataDrift.length,
   orphanedSchemas: orphanedSchemas.length,
@@ -388,6 +392,12 @@ const issueCount =
   summary.gatewayErrors +
   summary.metadataDrift +
   summary.orphanedSchemas;
+const blockingIssueCount =
+  summary.missingSchemaFile +
+  summary.blockingMissingGateway +
+  summary.gatewayErrors +
+  summary.metadataDrift +
+  summary.orphanedSchemas;
 
 // ---------------------------------------------------------------------------
 // Output
@@ -406,13 +416,17 @@ if (jsonOutput) {
 }
 
 // Human-readable summary always goes to stderr
-if (issueCount === 0) {
+if (blockingIssueCount === 0 && issueCount === 0) {
   process.stderr.write(
     `Schema health check PASSED: all ${summary.total} scopes are consistent.\n`
   );
+} else if (blockingIssueCount === 0) {
+  process.stderr.write(
+    `Schema health check PASSED with ${issueCount} inherited non-blocking issue(s).\n\n`
+  );
 } else {
   process.stderr.write(
-    `Schema health check FAILED: ${issueCount} issue(s) found\n\n`
+    `Schema health check FAILED: ${blockingIssueCount} blocking issue(s) found (${issueCount} total issue(s)).\n\n`
   );
 
   if (missingSchemaFile.length > 0) {
@@ -427,7 +441,7 @@ if (issueCount === 0) {
   if (missingGateway.length > 0) {
     process.stderr.write("Not registered in Gateway:\n");
     for (const r of missingGateway) {
-      const tag = r.isNew ? " [added in this PR]" : "";
+      const tag = r.isNew ? " [added in this PR]" : " [pre-existing debt]";
       process.stderr.write(`  - ${r.scope} (connector: ${r.connector})${tag}\n`);
     }
     process.stderr.write("\n");
@@ -463,9 +477,15 @@ if (issueCount === 0) {
     process.stderr.write("\n");
   }
 
-  process.stderr.write(
-    "These issues must be resolved before connectors can be used by Personal Servers.\n"
-  );
+  if (blockingIssueCount > 0) {
+    process.stderr.write(
+      "These blocking issues must be resolved before connectors can be used by Personal Servers.\n"
+    );
+  } else {
+    process.stderr.write(
+      "Inherited Gateway registration debt remains. This PR does not introduce new Gateway registration gaps.\n"
+    );
+  }
 }
 
-process.exit(issueCount === 0 ? 0 : 1);
+process.exit(blockingIssueCount === 0 ? 0 : 1);