feat(skills): add mssql-performance-review orchestrator (tier 1 β agentic core)#5
Merged
Merged
Conversation
β¦ntic core) Adds an agentic offline orchestrator skill that routes mixed SQL Server artifacts (or symptom descriptions) to the 15 specialised review skills, runs an adversarial root-cause check, and produces a single consolidated report with evidence chain, risk-rated fixes, and explicit rollback for every recommendation. This is tier 1 of the v4 roadmap (see backlog/performance-review-orchestrator-plan-v4.md): - Evidence chain (every Critical finding cites >=3 check IDs from >=2 skills) - Risk-aware recommendations (action, effort, window, risk, side effects, rollback, verification, confidence per fix) - Adversarial root-cause check (deliberate disproof attempt) - Confidence-driven early termination (stop when 3+ skills converge HIGH) Strictly offline β the orchestrator never opens a connection to SQL Server. All execution against the database is the user's action. Added: - skills/mssql-performance-review/SKILL.md (304 lines) - skills/mssql-performance-review/references/ (README, check-explanations, evidence-schema, risk-rubric, adversarial-prompts) - skills/mssql-performance-review/evals/evals.json (4 test prompts) - skills/mssql-performance-review/scripts/.gitkeep, assets/.gitkeep - example/mssql-performance-review/mixed-artifacts/ (sample inputs) - example/mssql-performance-review/mixed-artifacts-analysis.md (reference output) - example/mssql-performance-review/symptom-first-analysis.md (symptom-driven triage) - Companion-skill line in all 15 existing SKILL.md files - CLAUDE.md, README.md, PERFORMANCE_TUNING_GUIDE.md, LLM_COST_ESTIMATION.md updated for the 16th skill - PERFORMANCE_TUNING_GUIDE.md Skills at a Glance also gains the missing hadr-health-review row verify-docs.sh: 31 PASS, 0 WARN, 0 FAIL
Owner
Author
|
Fixed the off-by-one: two locations in skills/mssql-performance-review/SKILL.md said "14 specialised review skills" but the Companion Skills section lists 15. Changed both to "15" (line 15 in Purpose and line 199 in Output Format). verify-docs.sh still passes 31/31. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
mssql-performance-reviewβ an agentic offline orchestrator that routes mixed SQL Server artifacts (or symptom descriptions) to the 15 specialised review skills, runs an adversarial root-cause check, and emits a single consolidated report.This is tier 1 of the v4 roadmap (see
backlog/performance-review-orchestrator-plan-v4.mdin local backlog). Tier 1 delivers the trustworthy agentic core. Tier 2 (multi-model routing, DAG, domain memory, follow-up Q&A) and tier 3 (capture-bundle generator, verification checklist, baseline-diff loop) ship in subsequent PRs.What's new
--exhaustiveto override.Strictly offline
The orchestrator never opens a connection to SQL Server. All execution against the database is the user's action. Works in air-gapped, regulated, or third-party-DBA scenarios.
Files
New:
skills/mssql-performance-review/SKILL.md(304 lines)skills/mssql-performance-review/references/β README, check-explanations, evidence-schema, risk-rubric, adversarial-promptsskills/mssql-performance-review/evals/evals.jsonβ 4 test prompts (artifact-first, symptom-first, adversarial, baseline-diff)skills/mssql-performance-review/scripts/.gitkeep,assets/.gitkeepexample/mssql-performance-review/mixed-artifacts/β.sql+.sqlplan+ stats + wait statsexample/mssql-performance-review/mixed-artifacts-analysis.mdβ reference unified reportexample/mssql-performance-review/symptom-first-analysis.mdβ symptom-driven triage walkthroughUpdated:
SKILL.mdfiles (Companion Skills section)CLAUDE.mdβ Key Files, Skills tables, prefix map (dispatcher exemption noted)README.mdβ install line, full## mssql-performance-reviewsectionPERFORMANCE_TUNING_GUIDE.mdβ Skills at a Glance (+ orchestrator row, + missinghadr-health-reviewrow), new "I have a pile of mixed artifacts" scenarioLLM_COST_ESTIMATION.mdβ orchestrator size row (~7,500 tokens)Test plan
bash scripts/verify-docs.shβ 31 PASS, 0 WARN, 0 FAILno_contradictionresultmssql-performance-reviewas a Companion SkillRoadmap
feat/perf-review-orchestrator-v4-tier1feat/perf-review-orchestrator-v4-tier2feat/perf-review-orchestrator-v4-tier3π€ Generated with Claude Code