Skip to content

Commit a7a20ec

Browse files
committed
Use ENABLE_HTTPD alone; update httpd opts
Remove ENABLE_CONTENT from GD32 build files and treat ENABLE_HTTPD as sufficient for web/browser support. Update ArtNet controller/node to report WebBrowserSupport when ENABLE_HTTPD is defined (no longer requires ENABLE_CONTENT). Adjust HTTPD handler GCC pragmas to use CONFIG_HTTPD_OPTIMIZE_NONE to disable optimizations, prefer O3 if configured, otherwise O2. Also remove the ENABLE_CONTENT compile guard around serving embedded content so content handling is compiled with the HTTPD build.
1 parent 77345a5 commit a7a20ec

6 files changed

Lines changed: 9 additions & 11 deletions

File tree

gd32_emac_artnet_dmx_multi/Common.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ DEFINES+=RTL8201F_LED1_LINK_ALL
1515

1616
DEFINES+=DISPLAY_UDF
1717

18-
DEFINES+=ENABLE_HTTPD ENABLE_CONTENT
18+
DEFINES+=ENABLE_HTTPD
1919

2020
DEFINES+=DISABLE_RTC
2121
DEFINES+=DISABLE_FS

gd32_emac_e131_dmx_multi/Common.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ DEFINES+=RTL8201F_LED1_LINK_ALL
66

77
DEFINES+=DISPLAY_UDF
88

9-
DEFINES+=ENABLE_HTTPD ENABLE_CONTENT
9+
DEFINES+=ENABLE_HTTPD
1010

1111
DEFINES+=DISABLE_RTC
1212
DEFINES+=DISABLE_FS

gd32_emac_e131_dmx_multi/Makefile.GD32

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ DEFINES+=ENET_RXBUF_NUM=16 ENET_TXBUF_NUM=4
1414

1515
DEFINES+=DISPLAY_UDF
1616

17-
DEFINES+=ENABLE_HTTPD ENABLE_CONTENT
17+
DEFINES+=ENABLE_HTTPD
1818

1919
DEFINES+=DISABLE_RTC
2020
DEFINES+=DISABLE_FS

lib-artnet/src/controller/artnetcontroller.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ ArtNetController::ArtNetController()
103103
art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kDhcpCapable);
104104
art_poll_reply_.status2 |= network::iface::IsDhcpCapable() ? artnet::Status2::kDhcpCapable : static_cast<uint8_t>(0);
105105

106-
#if defined(ENABLE_HTTPD) && defined(ENABLE_CONTENT)
106+
#if defined(ENABLE_HTTPD)
107107
art_poll_reply_.status2 |= artnet::Status2::kWebBrowserSupport;
108108
#endif
109109

lib-artnet/src/node/artnetnode.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ void ArtNetNode::Start()
174174
artnet::Status2::kPortAddress15Bit | (artnet::kVersion >= 4 ? artnet::Status2::kSacnAbleToSwitch : artnet::Status2::kSacnNoSwitch);
175175
art_poll_reply_.status2 &= static_cast<uint8_t>(~artnet::Status2::kDhcpCapable);
176176
art_poll_reply_.status2 |= network::iface::IsDhcpCapable() ? artnet::Status2::kDhcpCapable : static_cast<uint8_t>(0);
177-
#if defined(ENABLE_HTTPD) && defined(ENABLE_CONTENT)
177+
#if defined(ENABLE_HTTPD)
178178
art_poll_reply_.status2 |= artnet::Status2::kWebBrowserSupport;
179179
#endif
180180
#if defined(OUTPUT_HAVE_STYLESWITCH)

lib-remoteconfig/src/httpd/httpdhandlerequest.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
#undef NDEBUG
2727
#endif
2828
#if defined(__GNUC__) && !defined(__clang__)
29-
#if defined(CONFIG_HTTPD_OPTIMIZE_O2) || defined(CONFIG_HTTPD_OPTIMIZE_O3)
29+
#if !defined(CONFIG_HTTPD_OPTIMIZE_NONE)
3030
#pragma GCC push_options
31-
#if defined(CONFIG_HTTPD_OPTIMIZE_O2)
32-
#pragma GCC optimize("O2")
33-
#else
31+
#if defined(CONFIG_HTTPD_OPTIMIZE_O3)
3432
#pragma GCC optimize("O3")
33+
#else
34+
#pragma GCC optimize("O2")
3535
#endif
3636
#endif
3737
#endif
@@ -519,7 +519,6 @@ http::Status HttpDeamonHandleRequest::HandleGet()
519519
}
520520
}
521521
}
522-
#if defined(ENABLE_CONTENT)
523522
else
524523
{
525524
const auto kIndex = html::GetFileIndex(uri_);
@@ -535,7 +534,6 @@ http::Status HttpDeamonHandleRequest::HandleGet()
535534
content_ = GetFileContent(&uri_[1], length, request_content_type_);
536535
}
537536
}
538-
#endif
539537

540538
if (length == 0)
541539
{

0 commit comments

Comments
 (0)