Replace hal timing with timing:: API

Replace legacy hal timing calls with the unified timing API across device and display code (hal_micros/hal_millis/udelay -> timing::Micros/ timing::Millis/ timing::DelayUs) and add timing.h includes where needed. Replace sentinel returns of static_cast<uint32_t>(~0) with UINT32_MAX. Refactor/clean up SPI/display headers and Paint implementation (formatting, brace/style changes, DrawLine integer handling), update copyright years in ST headers, and adjust dmxnode enum usage (PortDirection -> Direction). These changes unify timing, improve readability, and fix some portability/sentinel issues. Affected files include many under lib-device, lib-display, lib-displayudf, lib-osc, and lib-showfile.

Author: vanvught

lib-device/include/bwspilcd.h

@@ -28,7 +28,7 @@
 
 #include <cstdint>
 
-#include "hal_micros.h"
+#include "timing.h"
 
 #include "bw.h"
 
@@ -38,11 +38,11 @@ class BwSpiLcd : BwSpi
     {
         do
         {
-        } while ((hal::Micros() - m_nSpiWriteUs) < bw::lcd::spi::write_delay_us);
+        } while ((timing::Micros() - m_nSpiWriteUs) < bw::lcd::spi::write_delay_us);
 
         HAL_SPI::Write(pData, length);
 
-        m_nSpiWriteUs = hal::Micros();
+        m_nSpiWriteUs = timing::Micros();
     }
 
    public:
@@ -112,7 +112,7 @@ class BwSpiLcd : BwSpi
     bool IsConnected() { return m_IsConnected; }
 
    private:
-    uint32_t m_nSpiWriteUs = hal::Micros();
+    uint32_t m_nSpiWriteUs = timing::Micros();
 };
 
 #endif  // BWSPILCD_H_

lib-device/include/sc16is740.h

@@ -29,7 +29,7 @@
 #include <cstdint>
 
 #include "hal_i2c.h"
-#include "hal_millis.h"
+#include "timing.h"
 
 #include "sc16is7x0.h"
 
@@ -136,14 +136,14 @@ class SC16IS740 : HAL_I2C
 
     bool IsReadable(uint32_t time_out)
     {
-        const auto kMillis = hal::Millis();
+        const auto kMillis = timing::Millis();
         do
         {
             if (IsReadable())
             {
                 return true;
             }
-        } while ((hal::Millis() - time_out) < kMillis);
+        } while ((timing::Millis() - time_out) < kMillis);
 
         return false;
     }

lib-device/src/htu21d.cpp

@@ -71,7 +71,7 @@ uint16_t HTU21D::ReadRaw(uint8_t cmd)
 
     for (uint32_t i = 0; i < 8; ++i)
     {
-        udelay(10000);
+        timing::DelayUs(10000);
         HAL_I2C::Read(buf, 3);
 
         if ((buf[0] & 0x3) == 2)

lib-device/src/mcp3424.cpp

@@ -164,7 +164,7 @@ uint32_t MCP3424::GetRaw(uint32_t channel)
 
         if (timeout-- == 0)
         {
-            return static_cast<uint32_t>(~0);
+            return UINT32_MAX;
         }
     }
 
@@ -190,7 +190,7 @@ uint32_t MCP3424::GetRaw(uint32_t channel)
 
     assert(0);
     __builtin_unreachable();
-    return static_cast<uint32_t>(~0);
+    return UINT32_MAX;
 }
 
 double MCP3424::GetVoltage(uint32_t channel)

lib-device/src/sc16is740.cpp

@@ -28,7 +28,7 @@
 #include "sc16is740.h"
 #include "sc16is7x0.h"
 
-#include "hal_millis.h"
+#include "timing.h"
 #include "hal_i2c.h"
 #include "firmware/debug/debug_printbits.h"
  #include "firmware/debug/debug_debug.h"
@@ -190,11 +190,11 @@ void SC16IS740::ReadBytes(uint8_t *bytes, uint32_t& size, uint32_t time_out) {
 	uint32_t remaining = size;
 
 	while (remaining > 0) {
-		const uint32_t kMillis =hal::Millis();
+		const uint32_t kMillis =timing::Millis();
 		uint32_t available;
 
 		while ((available = ReadRegister(SC16IS7X0_RXLVL)) == 0) {
-			if ((hal::Millis() - time_out) > kMillis) {
+			if ((timing::Millis() - time_out) > kMillis) {
 				remaining = 0;
 				break;
 			}
@@ -218,11 +218,11 @@ void SC16IS740::FlushRead(uint32_t time_out) {
 	bool is_remaining = true;
 
 	while (is_remaining) {
-		const auto kMillis = hal::Millis();
+		const auto kMillis = timing::Millis();
 		uint32_t available;
 
 		while ((available = ReadRegister(SC16IS7X0_RXLVL)) == 0) {
-			if ((hal::Millis() - time_out) > kMillis) {
+			if ((timing::Millis() - time_out) > kMillis) {
 				is_remaining = false;
 				break;
 			}

lib-device/src/si7021.cpp

@@ -71,7 +71,7 @@ uint16_t SI7021::ReadRaw(uint8_t cmd)
 
     for (uint32_t i = 0; i < 8; ++i)
     {
-        udelay(10000);
+        timing::DelayUs(10000);
         HAL_I2C::Read(buf, 3);
 
         if ((buf[0] & 0x3) == 2)