chore: phpstan errors

Author: vardumper

tests/Unit/DependencyInjection/IbexaAutomaticMigrationsExtensionTest.php

@@ -35,4 +35,23 @@
         $registeredPath = key($paths);
         expect(str_contains($registeredPath, 'Resources/views'))->toBeTrue();
     });
+
+    it('load sets ibexa_automatic_migrations parameters', function () {
+        $container = new ContainerBuilder();
+        $ext = new IbexaAutomaticMigrationsExtension();
+
+        $ext->load([[]], $container);
+
+        expect($container->hasParameter('ibexa_automatic_migrations.enabled'))->toBeTrue();
+        expect($container->hasParameter('ibexa_automatic_migrations.types'))->toBeTrue();
+    });
+
+    it('load registers settings service in the container', function () {
+        $container = new ContainerBuilder();
+        $ext = new IbexaAutomaticMigrationsExtension();
+
+        $ext->load([[]], $container);
+
+        expect($container->hasDefinition('ibexa_automatic_migrations.settings_service'))->toBeTrue();
+    });
 });

tests/Unit/EventSubscriber/MigrationsMenuSubscriberTest.php

@@ -57,4 +57,31 @@
 
         $subscriber->onMainMenuConfigure($event);
     });
+
+    it('onMainMenuConfigure adds menu item when permission is granted', function () {
+        $permissionResolver = $this->createStub(PermissionResolver::class);
+        $permissionResolver->method('hasAccess')->willReturn(true);
+
+        $addChildCallCount = 0;
+        $childMenu = $this->createMock(ItemInterface::class);
+        $childMenu->method('addChild')->willReturnCallback(function () use (&$addChildCallCount, &$childMenu) {
+            $addChildCallCount++;
+            return $childMenu;
+        });
+
+        $menuFactory = $this->createStub(MenuItemFactory::class);
+        $menuFactory->method('createItem')->willReturn($this->createStub(ItemInterface::class));
+
+        $subscriber = new MigrationsMenuSubscriber($menuFactory, $permissionResolver);
+
+        $menu = $this->createStub(ItemInterface::class);
+        $menu->method('getChild')->willReturn($childMenu);
+
+        $factory = $this->createStub(\Knp\Menu\FactoryInterface::class);
+        $event = new ConfigureMenuEvent($factory, $menu, []);
+
+        $subscriber->onMainMenuConfigure($event);
+
+        expect($addChildCallCount)->toBe(1);
+    });
 });

tests/Unit/HelperTest.php

@@ -294,4 +294,52 @@
         expect(substr_count($content, 'match_tolerate_misses:'))->toBe(1);
         expect($content)->toContain('    match_tolerate_misses: true');
     });
+
+    it('returns true when file cannot be read', function () {
+        set_error_handler(fn () => true, E_WARNING);
+        try {
+            $result = Helper::fixKaliopMigrationYaml('/nonexistent_test_path_xyz/file.yml', new NullLogger());
+            expect($result)->toBeTrue();
+        } finally {
+            restore_error_handler();
+        }
+    });
+
+    it('inserts field-settings at correct position when block ends with blank line and has no validator-configuration', function () {
+        // The block collector includes trailing empty lines; the while loop on line 134
+        // must back up past the trailing blank before splicing field-settings in.
+        $yaml = "-\n    type: content_type\n    mode: create\n    attributes:\n        -\n            identifier: title\n            type: ibexa_string\n\n        -\n            identifier: body\n            type: ibexa_richtext\n";
+        file_put_contents($this->tmpFile, $yaml);
+
+        $result = Helper::fixKaliopMigrationYaml($this->tmpFile, new NullLogger());
+        $content = file_get_contents($this->tmpFile);
+
+        expect($result)->toBeTrue();
+        expect($content)->toContain('            field-settings: {  }');
+    });
+
+    it('inserts validator-configuration at correct position when ibexa_boolean block ends with blank line', function () {
+        // Block has field-settings but no validator-configuration, and ends with a blank line;
+        // the while loop on line 143 must back up past the trailing blank.
+        $yaml = "-\n    type: content_type\n    mode: create\n    attributes:\n        -\n            identifier: active\n            type: ibexa_boolean\n            field-settings: {  }\n\n        -\n            identifier: body\n            type: ibexa_richtext\n";
+        file_put_contents($this->tmpFile, $yaml);
+
+        $result = Helper::fixKaliopMigrationYaml($this->tmpFile, new NullLogger());
+        $content = file_get_contents($this->tmpFile);
+
+        expect($result)->toBeTrue();
+        expect($content)->toContain('            validator-configuration: {  }');
+    });
+
+    it('inserts match_tolerate_misses before sibling key that follows match block', function () {
+        // A non-8-space-indented key immediately after match: triggers the elseif branch (lines 205-207).
+        $yaml = "-\n    type: content_type\n    mode: delete\n    match:\n    content_type_identifier: some_type\n";
+        file_put_contents($this->tmpFile, $yaml);
+
+        $result = Helper::fixKaliopMigrationYaml($this->tmpFile, new NullLogger());
+        $content = file_get_contents($this->tmpFile);
+
+        expect($result)->toBeTrue();
+        expect($content)->toContain('    match_tolerate_misses: true');
+    });
 });