Skip to content

Commit a0255f0

Browse files
committed
fix: append root node in ComponentBuilder.php
1 parent fe98cbc commit a0255f0

7 files changed

Lines changed: 8 additions & 5 deletions

File tree

docs/phpmd.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Issues detected: 15
105105
| <span class="prio1">1</span> | src/Element/Void/Style.php | 128 | [StaticAccess](https://phpmd.org/rules/cleancode.html#staticaccess) | Avoid using static access to class `\Html\Enum\TypeStyleEnum` in method `setType`. |
106106
| <span class="prio1">1</span> | src/Element/Void/Track.php | 114 | [StaticAccess](https://phpmd.org/rules/cleancode.html#staticaccess) | Avoid using static access to class `\Html\Enum\KindEnum` in method `setKind`. |
107107
| <span class="prio1">1</span> | src/Service/ComponentBuilder.php | 54 | [ElseExpression](https://phpmd.org/rules/cleancode.html#elseexpression) | The method buildDOM uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. |
108-
| <span class="prio1">1</span> | src/Service/ComponentBuilder.php | 62 | [ElseExpression](https://phpmd.org/rules/cleancode.html#elseexpression) | The method buildDOM uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. |
108+
| <span class="prio1">1</span> | src/Service/ComponentBuilder.php | 63 | [ElseExpression](https://phpmd.org/rules/cleancode.html#elseexpression) | The method buildDOM uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. |
109109
| <span class="prio1">1</span> | src/Trait/GlobalAttributesTrait.php | 189 | [StaticAccess](https://phpmd.org/rules/cleancode.html#staticaccess) | Avoid using static access to class `\Html\Enum\AutoCapitalizeEnum` in method `setAutoCapitalize`. |
110110
| <span class="prio1">1</span> | src/Trait/GlobalAttributesTrait.php | 209 | [StaticAccess](https://phpmd.org/rules/cleancode.html#staticaccess) | Avoid using static access to class `\Html\Enum\ContentEditableEnum` in method `setContentEditable`. |
111111
| <span class="prio1">1</span> | src/Trait/GlobalAttributesTrait.php | 216 | [StaticAccess](https://phpmd.org/rules/cleancode.html#staticaccess) | Avoid using static access to class `\Html\Enum\ContentEditableEnum` in method `setContentEditable`. |
@@ -137,4 +137,4 @@ Issues detected: 76
137137

138138
Issues detected: 8
139139

140-
Sat Jul 12 05:55:45 PM CEST 2025
140+
Mon Jul 14 12:22:51 PM CEST 2025
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<div class="teaser"><h3>Teaser Component</h3><p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam in dui mauris. Vivamus hendrerit arcu sed erat molestie vehicula.</p><img src="/path/to/image.jpg" alt="Image"><a role="button" href="/path/to/page">Read more</a></div>
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<div class="teaser"><h3>{{ entry.title }}</h3><p>{{ entry.description }}</p><img src="{{ entry.image.url }}" alt="{{ entry.image.alt }}"><a role="button" href="{{ entry.url }}">{{ 'Read more'|t }}</a></div>

src/Command/CreateClassCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
/**
1616
* @usage make:classes [element]
17-
* @description Create a new component
17+
* @description Creates all or one HTML element class.
1818
* @tutorial an example element value can be div
1919
* @see https://developer.mozilla.org/en-US/docs/Web/HTML/Element
2020
*/

src/Interface/DOMNodeListDelegatorInterface.php

Whitespace-only changes.

src/Service/ComponentBuilder.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ private function buildDOM(HTMLDocumentDelegatorInterface $doc, array $nodeData,
5656
}
5757
}
5858

59-
// Append to parent or document
59+
// Append to parent node if set - or document if root node
6060
if ($parent === null) {
61-
$doc->appendChild($element);
61+
$importedNode = $doc->importNode($element->delegated, true);
62+
$doc->appendChild($importedNode);
6263
} else {
6364
$parent->appendChild($element);
6465
}

tests/Delegator/DOMNodeDelegatorTest.php

Whitespace-only changes.

0 commit comments

Comments
 (0)