File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 2626#include < cstring>
2727#include < utility>
2828
29- // FIXME: move it elsewhere
30- #define H5CPP_supported_elementary_types " supported elementary types ::= pod_struct | float | double | [signed](int8 | int16 | int32 | int64)"
29+ // H5CPP_supported_elementary_types is defined once in H5misc.hpp (the
30+ // canonical copy that includes `enum`); H5misc is always pulled in ahead of
31+ // this header via h5cpp/core, and the macro is only consumed by the
32+ // static_assert diagnostics in H5Dread/H5Dwrite. The duplicate definition
33+ // that used to live here conflicted with H5misc's and produced a redefinition
34+ // warning in every TU including core (#289).
3135
3236// stl detection with templates, this probably should stay until concepts become mainstream
3337namespace h5 ::meta {
You can’t perform that action at this time.
0 commit comments