Merge branch '18-build-add-code-coverage-report' into staging

Author: steven-varga

.github/workflows/ci.yml

@@ -308,4 +308,61 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: ./${{ steps.badge_dir.outputs.dir }}
-          destination_dir: ${{ steps.badge_dir.outputs.dir }}
+          destination_dir: ${{ steps.badge_dir.outputs.dir }}
+
+  coverage:
+    name: coverage / ubuntu-24.04 / gcc-14
+    runs-on: ubuntu-24.04
+    needs: build
+
+    env:
+      CC: gcc-14
+      CXX: g++-14
+      GCOV: gcov-14
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Install dependencies
+        shell: bash
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            cmake \
+            ninja-build \
+            gcc-14 \
+            g++-14 \
+            lcov
+
+      - name: Configure
+        shell: bash
+        run: |
+          cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14 -DCMAKE_C_FLAGS="--coverage -O0 -g" -DCMAKE_CXX_FLAGS="--coverage -O0 -g"
+
+      - name: Build
+        shell: bash
+        run: |
+          cmake --build build --parallel
+
+      - name: Test
+        shell: bash
+        run: |
+          ctest --test-dir build --output-on-failure --parallel
+
+      - name: Capture coverage
+        shell: bash
+        run: |
+          lcov --gcov-tool /usr/bin/gcov-14 --rc geninfo_unexecuted_blocks=1 --directory build --capture --output-file coverage.info
+          lcov --gcov-tool /usr/bin/gcov-14 --remove coverage.info '/usr/*' '*/test/*' '*/thirdparty/*' --ignore-errors unused --output-file coverage.info
+          lcov --gcov-tool /usr/bin/gcov-14 --list coverage.info
+
+      - name: Upload coverage reports to Codecov
+        uses: codecov/codecov-action@v5
+        with:
+          files: coverage.info
+          fail_ci_if_error: true
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

README.md

@@ -1,6 +1,6 @@
 
 [![CI](https://github.com/vargalabs/libdecimal/actions/workflows/ci.yml/badge.svg)](https://github.com/vargalabs/libdecimal/actions/workflows/ci.yml)
-[![codecov](https://codecov.io/gh/vargalabs/libdecimal/branch/main/graph/badge.svg)](https://codecov.io/gh/vargalabs/libdecimal)
+[![codecov](https://codecov.io/gh/vargalabs/libdecimal/graph/badge.svg?token=F6YCNG3HEY)](https://codecov.io/gh/vargalabs/libdecimal)
 [![MIT License](https://img.shields.io/badge/license-MIT-green.svg)](LICENSE)
 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.19323619.svg)](https://doi.org/10.5281/zenodo.19323619)
 [![GitHub release](https://img.shields.io/github/v/release/vargalabs/libdecimal.svg)](https://github.com/vargalabs/libdecimal/releases)
@@ -83,6 +83,12 @@ add_executable(app main.cpp)
 target_link_libraries(app PRIVATE libdecimal::libdecimal)
 ```
 
+## Attribution
+**LIBDECIMAL** builds on Intel’s LIBBID implementation of IEEE 754 decimal arithmetic. **The heavy lifting** — the arithmetic itself — comes from the work **of Marius Cornea, John Harrison, Cristina Anderson, and Evgeny Gvozdev**. **The** underlying **model** traces back **to Mike Cowlishaw** and the IEEE 754 standard.
+
+**The template/macro contraption** that makes it usable in modern C++, **along with the full decomposition of BID into sign, significand, and exponent** — that **is on me**.
+
+
 [200]: https://vargalabs.github.io/libdecimal/badges/ubuntu-22.04-gcc-13.svg
 [201]: https://vargalabs.github.io/libdecimal/badges/ubuntu-22.04-gcc-14.svg
 [202]: https://vargalabs.github.io/libdecimal/badges/ubuntu-22.04-gcc-15.svg

test/float-conversion.cpp

@@ -24,10 +24,7 @@ namespace test {
 
     template <class float_t>
     bool nearly_equal(float_t a, float_t b, float_t eps = static_cast<float_t>(1e-12)) {
-        if constexpr (std::is_same_v<float_t, long double>)
-            return std::fabsl(a - b) <= eps;
-        else
-            return std::fabs(a - b) <= eps;
+        return std::fabs(a - b) <= eps;
     }
 }
 

test/ops-transcendental.cpp

@@ -88,7 +88,7 @@ TEST_SUITE("transcendental functions::decimal64") {
 
     TEST_CASE("exp at easy points") {
         CHECK(test::as_long_double(math::exp(test::dec64_t{"0"})) == doctest::Approx(1.0L));
-        CHECK(test::as_long_double(math::exp(test::dec64_t{"1"})) == doctest::Approx(std::expl(1.0L)));
+        CHECK(test::as_long_double(math::exp(test::dec64_t{"1"})) == doctest::Approx(std::exp(1.0L)));
     }
 
     TEST_CASE("log at easy points") {
@@ -140,7 +140,7 @@ TEST_SUITE("transcendental functions::decimal128") {
 
     TEST_CASE("exp at easy points") {
         CHECK(test::as_long_double(math::exp(test::dec128_t{"0"})) == doctest::Approx(1.0L));
-        CHECK(test::as_long_double(math::exp(test::dec128_t{"1"})) == doctest::Approx(std::expl(1.0L)));
+        CHECK(test::as_long_double(math::exp(test::dec128_t{"1"})) == doctest::Approx(std::exp(1.0L)));
     }
 
     TEST_CASE("log at easy points") {