test(bottom-navigation): improve test coverage#1985
Open
aioya wants to merge 1 commit into
Open
Conversation
|
@aioya is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
There was a problem hiding this comment.
Pull request overview
Improves unit test coverage for the bottom-navigation component (including coverage of bottom-navigation-item behavior exercised through the parent), focusing on event handling and boundary/edge-case prop behavior.
Changes:
- Adds tests for
before-changerejection behavior and verifies noupdate:activeemission occurs. - Adds tests for
activeboundary handling (non-number, negative/out-of-range clamping, NaN, and length changes). - Adds tests covering FAB-related spacing classes and
bottom-navigation-itemrendering scenarios (badge/icon/slots/active selection/click).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| `, | ||
| }) | ||
|
|
||
| await new Promise((resolve) => setTimeout(resolve, 16)) |
| `, | ||
| }) | ||
|
|
||
| await new Promise((resolve) => setTimeout(resolve, 16)) |
| `, | ||
| }) | ||
|
|
||
| await new Promise((resolve) => setTimeout(resolve, 16)) |
| `, | ||
| }) | ||
|
|
||
| await new Promise((resolve) => setTimeout(resolve, 16)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Improve unit test coverage for the bottom-navigation component (including bottom-navigation-item, which is tested within this component's spec file). Pure test additions, no behavior changes.
Issues
N/A
Related Links
N/A