test(collapse): improve test coverage#1994
Open
aioya wants to merge 1 commit into
Open
Conversation
|
@aioya is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
@varlet/cli
@varlet/icons
@varlet/import-resolver
@varlet/preset-tailwindcss
@varlet/preset-unocss
@varlet/shared
@varlet/touch-emulator
@varlet/ui
@varlet/use
@varlet/vite-plugins
commit: |
aioya
force-pushed
the
test/collapse-coverage
branch
from
June 23, 2026 02:47
1dfb598 to
e6c6fa4
Compare
2 tasks
There was a problem hiding this comment.
Pull request overview
This PR improves unit test coverage for the Collapse / CollapseItem components, focusing on edge cases around accordion mode behavior and how unnamed items are matched by index. It is a test-only change intended to validate existing runtime behavior without altering component logic.
Changes:
- Added assertions that accordion mode can collapse an expanded item back to
undefined. - Added coverage for
nullaccordion model values (no items should expand). - Added coverage for unnamed item behavior (index-based matching) in both normal mode and
toggleAll, plus verifyingtoggleAllis a no-op in accordion mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aioya
force-pushed
the
test/collapse-coverage
branch
from
June 24, 2026 02:52
e6c6fa4 to
2315dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Improve unit test coverage for the collapse component. Pure test additions, no behavior changes.
Issues
N/A
Related Links
N/A