Move build-time feature checks / macros to new vtest extension "builtwith"

As we no longer compile vtest with every build, we can no longer use code in
vtest core to inform tests about compile time settings.

We move these to a new vtest extension which we do build.

Ref #4398

Author: nigoroll

bin/varnishtest/Makefile.am

@@ -127,12 +127,14 @@ else
 ################################################################################
 ## BEGIN vtc_varnish ext
 
-lib_LTLIBRARIES = libvtc_varnish.la libdummy.la
+lib_LTLIBRARIES = libvtc_varnish.la libvtc_builtwith.la libdummy.la
 
 # XXX TODO
 # - for actual move, the sources need to be relocated from VTest2 back to here
 # - for actual move, remove -DVTEST_WITH_...
-# - solve WITH_PERSISTENT_STORAGE
+# - remove feature tests now in builtwith from Vtest2 core
+# - remove pkg_version pkg_branch from Vtest2 core
+# - add libvtc_builtwith to Vtest2 as an example
 libvtc_varnish_la_SOURCES = \
 	vtest2/src/vtc_varnish.c \
 	vtest2/src/vtc_vsm.c \
@@ -151,6 +153,10 @@ libvtc_varnish_la_LIBADD = \
 	$(top_builddir)/lib/libvgz/libvgz.la \
 	${PTHREAD_LIBS} ${NET_LIBS} ${LIBM}
 
+libvtc_builtwith_la_SOURCES = vtc_ext_builtwith.c
+
+libvtc_builtwith_la_CFLAGS = @VTEST_CFLAGS@
+
 libdummy_la_SOURCES = libdummy.c
 
 bin_PROGRAMS = varnishtest

bin/varnishtest/tests/b00068.vtc

@@ -1,6 +1,6 @@
 varnishtest "Check timeout_linger"
 
-feature !workspace_emulator
+builtwith !workspace_emulator
 
 # XXX this test exploits the fact that the struct waited is
 # left near the free pointer of the session ws when a session

bin/varnishtest/tests/c00057.vtc

@@ -2,7 +2,7 @@ varnishtest	"test sigsegv handler"
 
 # Under ASAN, the stack layout is different and STACK OVERFLOW is
 # never printed.
-feature !asan
+builtwith !asan
 
 server s1 {
 	rxreq

bin/varnishtest/tests/e00029.vtc

@@ -1,6 +1,6 @@
 varnishtest "ESI max_esi_depth"
 
-feature !sanitizer
+builtwith !sanitizer
 
 # test that the default stack size is sufficient for hitting
 # max_esi_depth

bin/varnishtest/tests/o00006.vtc

@@ -1,6 +1,7 @@
 varnishtest "SES_Reserve_proto_priv() overflow"
 
-feature 64bit ipv4
+builtwith 64bit
+feature ipv4
 
 server s1 {
 	rxreq

bin/varnishtest/tests/p00000.vtc

@@ -1,6 +1,6 @@
 varnishtest "Test Basic persistence"
 
-feature persistent_storage
+builtwith persistent_storage
 
 process p1 -dump {
 	varnishd -spersistent -b ${localhost} -a :0 -d 2>&1

bin/varnishtest/tests/p00002.vtc

@@ -1,6 +1,6 @@
 varnishtest "Ban a persistent object"
 
-feature persistent_storage
+builtwith persistent_storage
 
 shell "rm -f ${tmpdir}/_.per[12]"
 

bin/varnishtest/tests/p00003.vtc

@@ -1,6 +1,6 @@
 varnishtest "Ban a persistent object"
 
-feature persistent_storage
+builtwith persistent_storage
 
 shell "rm -f ${tmpdir}/_.per"
 

bin/varnishtest/tests/p00004.vtc

@@ -1,6 +1,6 @@
 varnishtest "Check object references"
 
-feature persistent_storage
+builtwith persistent_storage
 
 shell "rm -f ${tmpdir}/_.per"
 

bin/varnishtest/tests/p00005.vtc

@@ -1,6 +1,6 @@
 varnishtest "Check expiry of non-instantiated object"
 
-feature persistent_storage
+builtwith persistent_storage
 
 shell "rm -f ${tmpdir}/_.per"