fix(ffi): read next_node/record_id from committer.live_state, not engine.state

When a WAL event_log is configured, engine.state is never mutated —
all writes go through committer.live_state. Reading next_record_id /
next_node_id from engine.state always returned 0 after the first
insert, causing ShadowApply(InvalidOperation) on every subsequent
create_node or insert_with_proof call.

Also fix valori_e2e_tracer.py to clean up test_e2e_db before each run
so replayed WAL events from a prior run don't cause ID collisions.

Author: varshith-Git

crates/valori-ffi/src/lib.rs

@@ -93,9 +93,8 @@ impl ValoricoreEngine {
         }
         let fxp_vec = FxpVector { data: fxp_data };
 
-        let rid = engine.state.next_record_id();
-
         if let Some(ref mut committer) = engine.event_committer {
+            let rid = committer.live_state().next_record_id();
             let event = KernelEvent::InsertRecord { id: rid, vector: fxp_vec, metadata: None, tag };
             // C-1: commit_event() already applies the event to live_state internally
             // (shadow-apply → persist → live-apply).  Do NOT call apply_committed_event again.
@@ -159,9 +158,12 @@ impl ValoricoreEngine {
         let k = NodeKind::from_u8(kind)
             .ok_or_else(|| PyValueError::new_err(format!("invalid NodeKind: {}", kind)))?;
 
-        let next_id = engine.state.next_node_id();
-
         if let Some(ref mut committer) = engine.event_committer {
+            // Must read next_node_id from the committer's live_state, not engine.state.
+            // engine.state is never mutated when a committer is present — only
+            // committer.live_state is. Using engine.state gives a stale (always-0)
+            // ID after the first node, causing ShadowApply(InvalidOperation).
+            let next_id = committer.live_state().next_node_id();
             let event = KernelEvent::CreateNode { id: next_id, kind: k, record: rid };
             // C-1: commit_event applies internally; do NOT call apply_committed_event.
             committer.commit_event(event).map_err(|e| {
@@ -275,10 +277,10 @@ impl ValoricoreEngine {
             let proof_bytes = generate_proof_bytes(&fixed_values);
             let proof_hex = hex::encode(&proof_bytes);
 
-            let rid = engine.state.next_record_id();
             let tag = tags[i];
 
             if let Some(ref mut committer) = engine.event_committer {
+                let rid = committer.live_state().next_record_id();
                 let event = KernelEvent::InsertRecord {
                     id: rid,
                     vector: fxp_vec,
@@ -432,9 +434,8 @@ impl ValoricoreEngine {
             }
         }
 
-        let rid = engine.state.next_record_id();
-
         if let Some(ref mut committer) = engine.event_committer {
+            let rid = committer.live_state().next_record_id();
             let event = KernelEvent::InsertRecord {
                 id: rid,
                 vector: fxp_vec,

scripts/valori_e2e_tracer.py

@@ -1,16 +1,17 @@
 import os
-import time
+import shutil
 import math
 # pyrefly: ignore [missing-import]
 from valoricore import MemoryClient
 
+DB_PATH = "./test_e2e_db"
+
 def mock_embed(text: str):
     """
     Deterministic mock embedding function returning exactly 384 floats.
     Used to bypass heavy ML model downloads in CI/CD environments.
     """
     base = sum(ord(c) for c in text)
-    # Generate 384 deterministic floats between -1.0 and 1.0
     return [math.sin(base + i) for i in range(384)]
 
 def print_header(title):
@@ -20,10 +21,15 @@ def print_header(title):
 
 def main():
     print_header("VALORI KERNEL: END-TO-END WORKFLOW TRACER")
-    
+
+    # Always start with a clean slate so replayed WAL events don't collide with
+    # the IDs this run expects.
+    if os.path.exists(DB_PATH):
+        shutil.rmtree(DB_PATH)
+
     # 1. Initialize MemoryClient
     print("\n[STEP 1] Initialization")
-    client = MemoryClient(path="./test_e2e_db", dim=384)
+    client = MemoryClient(path=DB_PATH, dim=384)
     print(f"✅ Client initialized.")
     print(f"🔐 Initial State Hash: {client.get_state_hash()}")
 
@@ -76,5 +82,9 @@ def main():
     print("🎉 END TO END WORKFLOW COMPLETE")
     print("="*60 + "\n")
 
+    # Clean up test database
+    if os.path.exists(DB_PATH):
+        shutil.rmtree(DB_PATH)
+
 if __name__ == "__main__":
     main()