Skip to content

Commit e3343fd

Browse files
committed
chore: Remove all compiler warnings (re-applied)
- Re-applied fixes lost during git reset: - Fixed unused imports in node (8 auto-fixes) - Fixed CLI bin warnings (bench_ingest, bench_filter, bench_recall) - Marked dead code with #[allow(dead_code)] (quant, safe_dist) - Prefixed unused variables with _ (_e, _packet_buffer, _slice) - Fixed SCALE import for no_std builds - Restored test imports in recovery.rs - Verified 0 warnings locally - All tests passing
1 parent febe01a commit e3343fd

13 files changed

Lines changed: 22 additions & 19 deletions

File tree

crates/cli/src/bin/bench_filter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use anyhow::Result;
2-
use valori_kernel::{ValoriKernel, types::FixedPointVector};
2+
use valori_kernel::ValoriKernel;
33

44
fn main() -> Result<()> {
55
println!("🚀 Starting Metadata Filter Benchmark...");

crates/cli/src/bin/bench_ingest.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ fn main() -> Result<()> {
3131
// Payload: [CMD(1)] + [ID(8)] + [DIM(2)] + [VALUES(128*4)]
3232
// Based on `crates/kernel/src/types.rs`
3333
let packet_size = 1 + 8 + 2 + (DIM * 4);
34-
let mut packet_buffer = vec![0u8; packet_size];
34+
let _packet_buffer = vec![0u8; packet_size];
3535

3636
// Constant Header Fields
3737
// Offset 0: CMD_INSERT = 1

crates/cli/src/bin/bench_recall.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ fn main() -> Result<()> {
186186

187187
// Pass/Fail Logic
188188
if total_queries > 0 {
189-
let r1 = (hits_at_1 as f64 / total_queries as f64);
189+
let r1 = hits_at_1 as f64 / total_queries as f64;
190190
if r1 > 0.90 {
191191
println!("🚀 SUCCESS: Recall@1 > 90%");
192192
} else {

node/src/engine.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ pub struct Engine<const MAX_RECORDS: usize, const D: usize, const MAX_NODES: usi
3434

3535
// Host-level extensions
3636
index: Box<dyn VectorIndex + Send + Sync>,
37+
#[allow(dead_code)]
3738
quant: Box<dyn Quantizer + Send + Sync>,
3839
pub metadata: Arc<MetadataStore>,
3940
pub snapshot_path: Option<std::path::PathBuf>,

node/src/events/event_log.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@ mod tests {
351351

352352
// Reopen and append more
353353
{
354-
let mut writer = EventLogWriter::<16>::open(&path).unwrap();
354+
let writer = EventLogWriter::<16>::open(&path).unwrap();
355355
assert_eq!(writer.event_count(), 5);
356356
}
357357
}

node/src/events/event_replay.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ pub fn read_event_log<const D: usize>(path: impl AsRef<Path>) -> Result<Vec<Kern
123123
}
124124
}
125125
}
126-
Err(e) => {
126+
Err(_e) => {
127127
// Check if we're at the tail (incomplete event from crash)
128128
if offset + 100 > buffer.len() {
129129
// Likely tail corruption from crash mid-write

node/src/main.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use valori_node::server::{build_router, ConcreteEngine, SharedEngine};
44
use std::sync::Arc;
55
use tokio::sync::Mutex;
66
use tokio::net::TcpListener;
7-
use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt};
87

98
#[tokio::main]
109
async fn main() {

node/src/recovery.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@
55
//! - Event log replay (Phase 23+: canonical truth)
66
//! - WAL replay (legacy fallback)
77
8-
use valori_kernel::state::command::Command;
98
use valori_kernel::state::kernel::KernelState;
10-
use valori_kernel::snapshot::blake3::hash_state_blake3;
119
use valori_kernel::snapshot::decode::decode_state;
1210

13-
use crate::wal_reader::{WalReader, WalReaderError};
14-
use crate::wal_writer::WalWriter; // Added for tests
11+
use crate::wal_reader::WalReader;
12+
// Added for tests
1513
use crate::errors::EngineError;
1614
use crate::events::event_replay::{recover_from_event_log, verify_snapshot_consistency};
1715
use crate::events::EventJournal;
@@ -149,6 +147,8 @@ mod tests {
149147
use super::*;
150148
use valori_kernel::types::id::RecordId;
151149
use valori_kernel::types::vector::FxpVector;
150+
use valori_kernel::state::command::Command;
151+
use crate::wal_writer::WalWriter;
152152
use tempfile::tempdir;
153153

154154
#[test]

node/src/server.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ async fn get_replication_events<const M: usize, const D: usize, const N: usize,
402402
).await?;
403403

404404
// 3. Convert mpsc Receiver to Body Stream
405-
use tokio_util::io::ReaderStream;
405+
406406
use futures::StreamExt;
407407

408408
let stream = tokio_stream::wrappers::ReceiverStream::new(rx_stream);
@@ -420,7 +420,7 @@ async fn get_replication_events<const M: usize, const D: usize, const N: usize,
420420
}
421421

422422
async fn get_replication_state() -> Json<serde_json::Value> {
423-
use crate::replication::{REPLICATION_STATUS, ReplicationState};
423+
use crate::replication::REPLICATION_STATUS;
424424
use std::sync::atomic::Ordering;
425425

426426
let status_u8 = REPLICATION_STATUS.load(Ordering::Relaxed);

node/src/structure/hnsw.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ impl HnswIndex {
106106
f_level.floor() as usize
107107
}
108108

109+
#[allow(dead_code)]
109110
fn safe_dist(&self, v1: Option<&Vec<f32>>, v2: Option<&Vec<f32>>) -> f32 {
110111
if let (Some(a), Some(b)) = (v1, v2) {
111112
self.dist(a, b)

0 commit comments

Comments
 (0)