Skip to content

Commit 1449737

Browse files
committed
fixes Dockerfile and GitHub action with Docker build
1 parent 00566d9 commit 1449737

2 files changed

Lines changed: 28 additions & 15 deletions

File tree

.github/workflows/build.yml

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,29 +11,42 @@ jobs:
1111
runs-on: ubuntu-latest
1212

1313
steps:
14-
- uses: actions/checkout@v2
14+
- uses: actions/checkout@v4
1515
with:
1616
fetch-depth: 0
1717

1818
- name: Set up JDK 11
19-
uses: actions/setup-java@v2
19+
uses: actions/setup-java@v3
2020
with:
2121
java-version: "11"
22-
distribution: "adopt"
22+
distribution: "temurin"
23+
cache: maven
2324

24-
- name: Build for push
25+
- name: Build with Maven
2526
run: mvn -B clean package -Dskip.docker.build=true
2627

27-
- name: Login to Docker Hub
28-
run: echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
29-
3028
- name: Inject slug/short variables
31-
uses: rlespinasse/github-slug-action@v3.x
29+
uses: rlespinasse/github-slug-action@v4.x
30+
31+
- name: Login to Docker Hub
32+
if: github.event_name != 'pull_request'
33+
uses: docker/login-action@v2
34+
with:
35+
username: ${{ secrets.DOCKER_USERNAME }}
36+
password: ${{ secrets.DOCKER_PASSWORD }}
3237

33-
- name: Building and publich Docker Image
34-
run: |
35-
IMAGE_NAME=${{ secrets.DOCKER_USERNAME }}/${{ secrets.APP_NAME }}
36-
TAG=`if [ "${{ env.GITHUB_REF_SLUG }}" == "master" ]; then echo "latest"; else echo ${{ env.GITHUB_REF_SLUG }}; fi`
38+
- name: Set up Docker Buildx
39+
if: github.event_name != 'pull_request'
40+
uses: docker/setup-buildx-action@v2
3741

38-
docker build -t $IMAGE_NAME:${{ env.GITHUB_SHA_SHORT }} -t $IMAGE_NAME:$TAG --build-arg JAR_FILE=target/${{ secrets.APP_NAME }}.jar .
39-
docker push $IMAGE_NAME --all-tags
42+
- name: Build and push Docker image
43+
if: github.event_name != 'pull_request'
44+
uses: docker/build-push-action@v4
45+
with:
46+
context: .
47+
push: true
48+
build-args: |
49+
JAR_FILE=target/${{ secrets.APP_NAME }}.jar
50+
tags: |
51+
${{ secrets.DOCKER_USERNAME }}/${{ secrets.APP_NAME }}:${{ env.GITHUB_SHA_SHORT }}
52+
${{ secrets.DOCKER_USERNAME }}/${{ secrets.APP_NAME }}:${{ env.GITHUB_REF_SLUG == 'master' && 'latest' || env.GITHUB_REF_SLUG }}

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ EXPOSE 8080
55
ENV APP_HOME /app
66
ENV JAVA_OPTS=""
77

8-
RUN adduser --system --uid 1000 springboot && \
8+
RUN useradd -r -u 1000 -m springboot && \
99
mkdir -p $APP_HOME/logs && \
1010
chown -R springboot $APP_HOME
1111
USER springboot

0 commit comments

Comments
 (0)