0.5.36 - 🐛 Fix router priority ordering (HALF_OPEN skip)

Bundles router priority fix + probe-loop hardening, provider-key-test
re-exports completing #121, and @MoriDanWork contributor credit.

- Router: sort by explicit priority BEFORE circuit state so a high-priority
  HALF_OPEN model is no longer skipped for a lower-priority CLOSED one.
- Probe loop: watchdog cleanup, lastProbeAt tracking, try/catch around cycles.
- key-handler: re-export shared provider-key-test helpers (finishes #121).
- Docs: credit @MoriDanWork in README + AGENTS.md.

Author: vava-nessa

AGENTS.md

@@ -88,6 +88,7 @@ When new PRs are merged, add the contributor's GitHub handle to the footer in `b
 - @whit3rabbit
 - @PhucTruong-ctrl
 - @stgreenb
+- @MoriDanWork
 
 ## Testing the TUI with tmux
 

README.md

@@ -676,6 +676,7 @@ Telemetry is enabled by default and can be disabled with any of the following:
     <td align="center" width="120"><a href="https://github.com/chindris-mihai-alexandru"><img src="https://avatars.githubusercontent.com/u/12643176?v=4&s=80" width="80" height="80" style="border-radius:50%" alt="chindris-mihai-alexandru"></a></td>
     <td align="center" width="120"><a href="https://github.com/serajbaltu"><img src="https://avatars.githubusercontent.com/u/90699173?v=4&s=80" width="80" height="80" style="border-radius:50%" alt="serajbaltu"></a></td>
     <td align="center" width="120"><a href="https://github.com/stgreenb"><img src="https://avatars.githubusercontent.com/u/18483964?v=4&s=80" width="80" height="80" style="border-radius:50%" alt="stgreenb"></a></td>
+    <td align="center" width="120"><a href="https://github.com/MoriDanWork"><img src="https://avatars.githubusercontent.com/u/55363096?v=4&s=80" width="80" height="80" style="border-radius:50%" alt="MoriDanWork"></a></td>
   </tr>
   <tr>
     <td align="center"><a href="https://github.com/vava-nessa"><sub><b>vava-nessa</b></sub></a></td>
@@ -686,6 +687,7 @@ Telemetry is enabled by default and can be disabled with any of the following:
     <td align="center"><a href="https://github.com/chindris-mihai-alexandru"><sub><b>chindris-mihai-alexandru</b></sub></a></td>
     <td align="center"><a href="https://github.com/serajbaltu"><sub><b>serajbaltu</b></sub></a></td>
     <td align="center"><a href="https://github.com/stgreenb"><sub><b>stgreenb</b></sub></a></td>
+    <td align="center"><a href="https://github.com/MoriDanWork"><sub><b>MoriDanWork</b></sub></a></td>
   </tr>
 </table>
 

changelog/v0.5.36.md

@@ -0,0 +1,13 @@
+# Changelog v0.5.36 - 2026-06-20
+
+### Fixed
+- **Router priority ordering now respects explicit priority over circuit state.** Previously, routing candidates were ordered strictly by circuit state (`CLOSED` candidates always before `HALF_OPEN`), then by priority and health score. This meant a high-priority model sitting in `HALF_OPEN` recovery could be skipped in favor of a lower-priority `CLOSED` model — defeating the whole point of explicit priority levels. The comparator now sorts by **explicit priority first**, then by circuit state (`CLOSED` before `HALF_OPEN`), then by health score. Higher-priority models are never again jumped over just because they are mid-recovery.
+
+### Changed
+- **Probe loop hardening.** `scheduleProbeLoop()` now clears a stale `probeWatchdog` timer alongside the main probe timer, tracks `lastProbeAt` timestamps after every successful cycle, and wraps the scheduling body in a `try/catch` so a single failed probe cycle can no longer destabilize the background routing daemon. Results in more reliable health-check cadences across the CLI, web, and Tauri surfaces (shared core).
+
+### Added
+- **Public re-exports of the provider-key-test helpers** from `key-handler.js` (`buildProviderModelsUrl`, `parseProviderModelIds`, `listProviderTestModels`, `classifyProviderTestOutcome`, `buildProviderTestDetail`). Completes the shared-module refactor introduced in #121 (provider key testing moved to `src/core/provider-key-tester.js`) so the TUI key-handler exposes the same surface other modules already consume.
+
+### Docs
+- **Credited @MoriDanWork** in the README contributors table and the AGENTS.md contributor list for PR #121 (move provider key testing to a shared module).

package.json

@@ -1,6 +1,6 @@
 {
   "name": "free-coding-models",
-  "version": "0.5.35",
+  "version": "0.5.36",
   "description": "Find the fastest coding LLM models in seconds — ping free models from multiple providers, pick the best one for OpenCode, Cursor, or any AI coding assistant.",
   "keywords": [
     "nvidia",

src/core/router-daemon.js

@@ -1193,12 +1193,24 @@ class RouterRuntime {
       if (!this.getApiKeyForProvider(candidate.provider)) return false
       return candidate.circuit?.state === 'CLOSED' || candidate.circuit?.state === 'HALF_OPEN'
     })
-    const closed = usable.filter((candidate) => candidate.circuit.state === 'CLOSED')
-    const halfOpen = usable.filter((candidate) => candidate.circuit.state === 'HALF_OPEN')
-    // 📖 Priority ascending (1 before 2); within the same priority, healthier
-    // 📖 score wins so cold-start ties resolve deterministically.
-    const byPriorityThenHealth = (a, b) => a.priority - b.priority || b.score - a.score
-    return [...closed.sort(byPriorityThenHealth), ...halfOpen.sort(byPriorityThenHealth)]
+    // 📖 New ordering: prioritize by explicit priority first, then by circuit state
+    // 📖 (CLOSED before HALF_OPEN), and finally by health score (higher is better).
+    // 📖 This ensures a higher‑priority model is never skipped just because it is
+    // 📖 in HALF_OPEN while a lower‑priority CLOSED model is available.
+    const stateOrder = { CLOSED: 0, HALF_OPEN: 1 }
+    const comparator = (a, b) => {
+      if (a.priority !== b.priority) return a.priority - b.priority
+      const aState = a.circuit?.state || 'UNKNOWN'
+      const bState = b.circuit?.state || 'UNKNOWN'
+      if (aState !== bState) {
+        const aRank = stateOrder[aState] ?? 2
+        const bRank = stateOrder[bState] ?? 2
+        return aRank - bRank
+      }
+      // higher score first
+      return b.score - a.score
+    }
+    return usable.sort(comparator)
   }
 
   // 📖 getRoutingOrder - slim projection of getRoutingCandidates for the /stats
@@ -1738,27 +1750,48 @@ class RouterRuntime {
   }
 
   scheduleProbeLoop() {
+    // Clear any existing timers
     if (this.probeTimer) clearInterval(this.probeTimer)
+    if (this.probeWatchdog) clearInterval(this.probeWatchdog)
     for (const timeout of this.probeTimeouts) clearTimeout(timeout)
     this.probeTimeouts.clear()
+
     const router = this.routerConfig()
     const interval = router.probeIntervals[router.probeMode] || DEFAULT_ROUTER_SETTINGS.probeIntervals.balanced
+    // Track last successful probe cycle timestamp
+    this.lastProbeAt = Date.now()
+
     this.probeTimer = setInterval(() => {
-      const set = this.getSet()
-      if (!set || this.shuttingDown) return
-      const candidates = this.scoreCandidates(set)
-        .filter((candidate) => candidate.catalog?.routeable && !candidate.circuit?.stale)
-      const stagger = candidates.length > 0 ? Math.max(250, Math.floor(interval / candidates.length)) : interval
-      candidates.forEach((candidate, index) => {
-        const timeout = setTimeout(() => {
-          this.probeTimeouts.delete(timeout)
-          void this.probeCandidate(candidate, { eco: router.probeMode === 'eco' })
-        }, index * stagger)
-        timeout.unref?.()
-        this.probeTimeouts.add(timeout)
-      })
+      try {
+        const set = this.getSet()
+        if (!set || this.shuttingDown) return
+        const candidates = this.scoreCandidates(set)
+          .filter((candidate) => candidate.catalog?.routeable && !candidate.circuit?.stale)
+        const stagger = candidates.length > 0 ? Math.max(250, Math.floor(interval / candidates.length)) : interval
+        candidates.forEach((candidate, index) => {
+          const timeout = setTimeout(() => {
+            this.probeTimeouts.delete(timeout)
+            void this.probeCandidate(candidate, { eco: router.probeMode === 'eco' })
+          }, index * stagger)
+          timeout.unref?.()
+          this.probeTimeouts.add(timeout)
+        })
+        // Update timestamp after scheduling probes
+        this.lastProbeAt = Date.now()
+      } catch (err) {
+        this.logger.error('[ProbeLoop] error', { error: err })
+      }
     }, interval)
     this.probeTimer.unref?.()
+
+    // Watchdog: if no successful cycle for 3x interval, restart loop
+    this.probeWatchdog = setInterval(() => {
+      if (this.lastProbeAt && Date.now() - this.lastProbeAt > interval * 3) {
+        this.logger.warn('[ProbeLoop] stall detected, restarting probe loop')
+        this.scheduleProbeLoop()
+      }
+    }, interval)
+    this.probeWatchdog.unref?.()
   }
 
   async routeRequest({ req, res, body, setName, requestId }) {
@@ -2357,6 +2390,7 @@ class RouterRuntime {
       this.markSetCustomized()
       this.broadcast('set_change', { activeSet: this.routerConfig().activeSet, set: name, action: 'add', model: newEntry })
       sendJson(res, 201, { set: normalized.sets[name], router: normalized }, { 'x-request-id': requestId })
+      void this.runProbeBurst()
       return
     }
 

src/tui/key-handler.js

@@ -3484,3 +3484,11 @@ export function createMouseEventHandler(ctx) {
     // 📖 Clicks outside any recognized zone are silently ignored.
   }
 }
+
+export {
+  buildProviderModelsUrl,
+  parseProviderModelIds,
+  listProviderTestModels,
+  classifyProviderTestOutcome,
+  buildProviderTestDetail,
+};