Skip to content

Commit cd739a2

Browse files
committed
Update: modify 24 file(s)
1 parent 220bb3e commit cd739a2

24 files changed

Lines changed: 67 additions & 57 deletions

examples/scripts/aggregate_metrics_demo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ def demonstrate_deprecation_warning():
212212
warnings.simplefilter("always")
213213

214214
# This will trigger a deprecation warning
215-
field = ComparableField(aggregate=True, comparator=ExactComparator())
215+
ComparableField(aggregate=True, comparator=ExactComparator())
216216

217217
if w:
218218
print(f" Warning: {w[0].message}")

examples/scripts/bulk_evaluation_demo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def demo_evaluation_with_output():
249249
evaluator.update(gt_doc, pred_doc, doc_id)
250250

251251
# Get results and save metrics
252-
result = evaluator.compute()
252+
evaluator.compute()
253253
evaluator.save_metrics(metrics_file)
254254

255255
print("\n💾 Output Files Created:")
@@ -341,7 +341,7 @@ def main():
341341
print("=" * 60)
342342

343343
# Demo 1: Basic bulk evaluation
344-
evaluator = demo_basic_bulk_evaluation()
344+
demo_basic_bulk_evaluation()
345345

346346
# Demo 2: Batch processing
347347
demo_batch_processing()

src/stickler/comparators/__init__.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,19 @@
1616

1717
# Import BERTComparator if evaluate is available
1818
try:
19-
from stickler.comparators.bert import BERTComparator
19+
from stickler.comparators.bert import BERTComparator # noqa: F401
2020

2121
BERT_AVAILABLE = True
2222
except ImportError:
2323
BERT_AVAILABLE = False
2424

2525
# Import FuzzyComparator and Fuzz alias only if rapidfuzz is available
2626
try:
27-
from stickler.comparators.fuzzy import RAPIDFUZZ_AVAILABLE, Fuzz, FuzzyComparator
27+
from stickler.comparators.fuzzy import ( # noqa: F401
28+
RAPIDFUZZ_AVAILABLE,
29+
Fuzz,
30+
FuzzyComparator,
31+
)
2832
except ImportError:
2933
RAPIDFUZZ_AVAILABLE = False
3034

src/stickler/reporting/html/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,7 @@
99

1010
__all__ = [
1111
"EvaluationHTMLReporter",
12-
"ReportConfig"
12+
"ReportConfig",
13+
"SectionGenerator",
14+
"VisualizationEngine"
1315
]

src/stickler/structured_object_evaluator/models/configuration_helper.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,14 @@
55
"""
66

77
import inspect
8-
from typing import Any, Dict, Union, get_args, get_origin
8+
from typing import TYPE_CHECKING, Any, Dict, Union, get_args, get_origin
99

1010
from stickler.comparators.levenshtein import LevenshteinComparator
11+
12+
if TYPE_CHECKING:
13+
from stickler.structured_object_evaluator.models.comparison_info import (
14+
ComparableFieldConfig,
15+
)
1116
from stickler.comparators.structured import StructuredModelComparator
1217

1318

tests/common/comparators/test_llm.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def test_compare_with_custom_prompt(self, mock_bedrock):
167167
mock_bedrock.return_value = mock_client
168168

169169
custom_prompt = "Custom prompt {value1} vs {value2}"
170-
comparator = LLMComparator(
170+
LLMComparator(
171171
model_name="test-model", prompt_template=custom_prompt
172172
)
173173

@@ -380,7 +380,7 @@ def test_get_comparison_details_error_handling(self):
380380

381381
assert "error" in details
382382
assert "comparison_result" in details
383-
assert details["comparison_result"] == False
383+
assert not details["comparison_result"]
384384

385385
def test_string_representation(self):
386386
"""Test string representations for serialization."""
@@ -477,20 +477,20 @@ def test_get_comparison_details_comprehensive_error_handling(self):
477477
self.mock_agent.side_effect = NoCredentialsError()
478478
details = self.comparator.get_comparison_details("value1", "value2")
479479
assert "error" in details
480-
assert details["comparison_result"] == False
480+
assert not details["comparison_result"]
481481

482482
# Test ClientError
483483
error_response = {'Error': {'Code': 'ThrottlingException', 'Message': 'Rate exceeded'}}
484484
self.mock_agent.side_effect = ClientError(error_response, 'InvokeModel')
485485
details = self.comparator.get_comparison_details("value1", "value2")
486486
assert "error" in details
487-
assert details["comparison_result"] == False
487+
assert not details["comparison_result"]
488488

489489
# Test generic exception
490490
self.mock_agent.side_effect = Exception("Generic error")
491491
details = self.comparator.get_comparison_details("value1", "value2")
492492
assert "error" in details
493-
assert details["comparison_result"] == False
493+
assert not details["comparison_result"]
494494

495495
def test_model_initialization_error(self):
496496
"""Test error handling during model initialization."""

tests/structured_object_evaluator/test_aggregate_contact_issue.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ def test_contact_object_level_metrics_not_rollup():
8080
expected_contact_fa = 0 # No false alarms (both sides have 1 contact)
8181
expected_contact_fp = 1 # fp = fa + fd = 0 + 1 = 1
8282
expected_contact_tp = 0 # No true positives
83-
expected_contact_tn = 0 # No true negatives
8483
expected_contact_fn = 0 # No false negatives
8584

8685
# CURRENT BUG: These will fail because it's rolling up nested field metrics (fd=1, fa=1, fp=2)

tests/structured_object_evaluator/test_comparable_field_fix.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ class TestModel(StructuredModel):
242242
assert isinstance(config.comparator, CustomTestComparator)
243243
assert config.threshold == 0.75
244244
assert config.weight == 2.5
245-
assert config.clip_under_threshold == False
245+
assert not config.clip_under_threshold
246246

247247
def test_multiple_custom_comparators(self):
248248
"""Test that multiple different custom comparators can coexist."""

tests/structured_object_evaluator/test_comparators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
FUZZY_AVAILABLE = False
1616

1717
try:
18-
from stickler.comparators.semantic import SemanticComparator
18+
from stickler.comparators.semantic import SemanticComparator # noqa: F401
1919

2020
SEMANTIC_AVAILABLE = True
2121
except ImportError:

tests/structured_object_evaluator/test_confusion_matrix_metrics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ def test_nested_structured_models():
356356

357357
# Create test nested models
358358
details1 = SimpleModel(name="Details 1", count=1, description="First details")
359-
details2 = SimpleModel(name="Details 2", count=2, description=None)
359+
SimpleModel(name="Details 2", count=2, description=None)
360360

361361
# Similar but not exact nested model
362362
details1_similar = SimpleModel(name="Details 1", count=1, description="First")

0 commit comments

Comments
 (0)