chore: 升级 shadcn-vue 组件到v4最新版#7972
Open
xingyu4j wants to merge 20 commits into
Open
Conversation
xingyu4j
requested review from
a team,
anncwb,
jinmao88,
mynetfan and
vince292007
as code owners
|
Contributor
|
Important Review skippedToo many files! This PR contains 238 files, which is 88 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (238)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Really? 239 files, bro. You should split this into several PRs. Start with the main changes first, then follow up with smaller PRs afterward. Honestly, this repo is getting messy because of these huge chore PRs. It’s great that the repo is active, but you also need to consider the other users. Also this is not a chore anymore! This is a FEATURE |
Contributor
Author
These are primarily component upgrades for shadcn-vue |
Contributor
Author
These components are still stuck on v3 and haven't been updated for nearly two years. |
Contributor
|
As I’ve said, the proper approach here is to split this into several PRs. This is not just a simple chore, these are major upgrades and feature changes. Putting 239 files into a single PR is just too much, bro. Right? Your PR is really great, but it’s just too much for a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
pnpm-lock.yamlunless you introduce a new test example.Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.