fix: harden diagnostics for large configs

javazys · javazys · commit a20b03036f85 · 2026-07-18T23:32:43.000+08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,15 @@
 
 All notable user-facing changes are recorded here. This project follows semantic versioning while it is in the `0.x` development series.
 
+## [0.1.38] - 2026-07-18
+
+### Fixed
+
+- `supertask doctor` now reads large resolved OpenCode configurations through a private temporary file, avoiding truncated JSON when OpenCode exits before a captured stdout pipe is fully drained.
+- Successful runs no longer label truncated or unstructured JSONL fragments as failure reasons in task details and execution logs.
+
+[0.1.38]: https://github.com/vbgate/opencode-supertask/compare/v0.1.37...v0.1.38
+
 ## [0.1.37] - 2026-07-18
 
 ### Fixed
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "opencode-supertask",
-    "version": "0.1.37",
+    "version": "0.1.38",
     "description": "AI Agent 任务调度系统 — OpenCode 插件 + CLI + Gateway 常驻进程",
     "type": "module",
     "main": "dist/plugin/supertask.js",
diff --git a/src/daemon/update.ts b/src/daemon/update.ts
@@ -1,6 +1,16 @@
 import { spawnSync } from 'child_process';
-import { existsSync, readFileSync, readdirSync, realpathSync } from 'fs';
-import { homedir } from 'os';
+import {
+    chmodSync,
+    closeSync,
+    existsSync,
+    mkdtempSync,
+    openSync,
+    readFileSync,
+    readdirSync,
+    realpathSync,
+    rmSync,
+} from 'fs';
+import { homedir, tmpdir } from 'os';
 import { dirname, join, resolve } from 'path';
 import { compareSemanticVersions, isSemanticVersion } from '@core/semver';
 
@@ -325,11 +335,6 @@ export function resolveConfiguredPluginSpec(value: unknown): ConfiguredPluginSpe
 }
 
 export function getOpenCodePluginDiagnostic(): OpenCodePluginDiagnostic {
-    const result = spawnSync(opencodeBin(), ['debug', 'config', '--pure'], {
-        encoding: 'utf8',
-        env: process.env,
-        timeout: 30_000,
-    });
     const failed = (message: string): OpenCodePluginDiagnostic => ({
         ok: false,
         spec: '',
@@ -339,53 +344,81 @@ export function getOpenCodePluginDiagnostic(): OpenCodePluginDiagnostic {
         packageDir: null,
         error: message,
     });
-    if (result.error) {
-        return failed(`[supertask] 无法读取 OpenCode 最终配置: ${result.error.message}`);
-    }
-    if (result.status !== 0) {
-        const detail = `${result.stderr ?? ''}`.trim();
-        return failed(`[supertask] 无法读取 OpenCode 最终配置: ${detail || `退出码 ${result.status}`}`);
-    }
+    let outputDirectory: string | null = null;
+    let outputFd: number | null = null;
 
-    let config: unknown;
     try {
-        config = JSON.parse(`${result.stdout ?? ''}`);
-    } catch {
-        return failed('[supertask] OpenCode 最终配置不是有效 JSON');
-    }
+        outputDirectory = mkdtempSync(join(tmpdir(), 'opencode-supertask-config-'));
+        chmodSync(outputDirectory, 0o700);
+        const outputPath = join(outputDirectory, 'resolved-config.json');
+        outputFd = openSync(outputPath, 'w', 0o600);
+        const result = spawnSync(opencodeBin(), ['debug', 'config', '--pure'], {
+            encoding: 'utf8',
+            env: process.env,
+            timeout: 30_000,
+            stdio: ['ignore', outputFd, 'pipe'],
+        });
+        closeSync(outputFd);
+        outputFd = null;
+        if (result.error) {
+            return failed(`[supertask] 无法读取 OpenCode 最终配置: ${result.error.message}`);
+        }
+        if (result.status !== 0) {
+            const detail = `${result.stderr ?? ''}`.trim();
+            return failed(`[supertask] 无法读取 OpenCode 最终配置: ${detail || `退出码 ${result.status}`}`);
+        }
 
-    let configured: ConfiguredPluginSpec;
-    try {
-        configured = resolveConfiguredPluginSpec(config);
-    } catch (error) {
-        return failed(error instanceof Error ? error.message : String(error));
-    }
-    if (!configured.exact || configured.version === null) {
-        return {
-            ok: false,
-            ...configured,
-            cachedVersion: null,
-            packageDir: null,
-            error: `[supertask] OpenCode 插件必须固定精确版本，不能使用 ${configured.spec}`,
-        };
-    }
-    try {
-        const installed = resolveInstalledPluginVersion(configured.version);
-        return {
-            ok: true,
-            ...configured,
-            cachedVersion: installed.version,
-            packageDir: installed.packageDir,
-            error: null,
-        };
+        let config: unknown;
+        try {
+            config = JSON.parse(readFileSync(outputPath, 'utf8'));
+        } catch {
+            return failed('[supertask] OpenCode 最终配置不是有效 JSON');
+        }
+
+        let configured: ConfiguredPluginSpec;
+        try {
+            configured = resolveConfiguredPluginSpec(config);
+        } catch (error) {
+            return failed(error instanceof Error ? error.message : String(error));
+        }
+        if (!configured.exact || configured.version === null) {
+            return {
+                ok: false,
+                ...configured,
+                cachedVersion: null,
+                packageDir: null,
+                error: `[supertask] OpenCode 插件必须固定精确版本，不能使用 ${configured.spec}`,
+            };
+        }
+        try {
+            const installed = resolveInstalledPluginVersion(configured.version);
+            return {
+                ok: true,
+                ...configured,
+                cachedVersion: installed.version,
+                packageDir: installed.packageDir,
+                error: null,
+            };
+        } catch (error) {
+            return {
+                ok: false,
+                ...configured,
+                cachedVersion: null,
+                packageDir: null,
+                error: error instanceof Error ? error.message : String(error),
+            };
+        }
     } catch (error) {
-        return {
-            ok: false,
-            ...configured,
-            cachedVersion: null,
-            packageDir: null,
-            error: error instanceof Error ? error.message : String(error),
-        };
+        return failed(`[supertask] 无法读取 OpenCode 最终配置: ${error instanceof Error ? error.message : String(error)}`);
+    } finally {
+        if (outputFd !== null) {
+            try {
+                closeSync(outputFd);
+            } catch {
+                // The descriptor may already be closed after a spawn failure.
+            }
+        }
+        if (outputDirectory !== null) rmSync(outputDirectory, { recursive: true, force: true });
     }
 }
 
diff --git a/src/web/index.tsx b/src/web/index.tsx
@@ -394,7 +394,7 @@ function shellQuote(value: string): string {
     return `'${value.replace(/'/g, `'"'"'`)}'`;
 }
 
-export function presentRunLog(log: string): RunLogPresentation {
+export function presentRunLog(log: string, includeErrors = true): RunLogPresentation {
     let command: RunCommandPresentation | null = null;
     const textParts: string[] = [];
     const errors: string[] = [];
@@ -407,7 +407,7 @@ export function presentRunLog(log: string): RunLogPresentation {
         try {
             parsed = recordValue(JSON.parse(trimmed) as unknown);
         } catch {
-            errors.push(line);
+            if (includeErrors) errors.push(line);
             continue;
         }
         if (!parsed) continue;
@@ -443,7 +443,7 @@ export function presentRunLog(log: string): RunLogPresentation {
         const error = typeof parsed.error === 'string'
             ? parsed.error
             : typeof part?.error === 'string' ? part.error : null;
-        if (error) errors.push(error);
+        if (error && includeErrors) errors.push(error);
     }
 
     return {
@@ -454,8 +454,8 @@ export function presentRunLog(log: string): RunLogPresentation {
     };
 }
 
-function renderRunLog(runId: number, taskName: string, log: string, locale: Locale): string {
-    const presentation = presentRunLog(log);
+function renderRunLog(runId: number, taskName: string, log: string, locale: Locale, includeErrors: boolean): string {
+    const presentation = presentRunLog(log, includeErrors);
     const command = presentation.command
         ? `<div class="run-command"><div class="log-section-head"><strong>${t(locale, 'logs.command')}</strong><button type="button" class="btn" onclick="copyRunCommand(${runId})">${icon('copy')}${t(locale, 'action.copyCommand')}</button></div><div class="command-cwd">${esc(presentation.command.cwd)}</div><pre id="command-${runId}">${esc(presentation.command.command)}</pre></div>`
         : '';
@@ -870,7 +870,7 @@ app.get('/runs', async (c) => {
     const rows = runs.map((run) => {
         const status = safeStatus(run.status);
         const resumable = isValidSessionId(run.sessionId);
-        const log = run.log ? renderRunLog(run.id, run.taskName, run.log, locale) : '';
+        const log = run.log ? renderRunLog(run.id, run.taskName, run.log, locale, run.status !== 'done') : '';
         return `<tr class="run-summary-row">
           <td class="faint" data-label="${t(locale, 'table.run')}">#${run.id}</td>
           <td data-primary data-label="${t(locale, 'table.task')}"><div class="task-name">${esc(run.taskName)} <span class="faint">#${run.taskId}</span></div>${run.model ? `<div style="margin-top:4px"><span class="tag">${esc(run.model)}</span></div>` : ''}</td>
@@ -1012,7 +1012,7 @@ app.get('/api/tasks/:id', async (c) => {
     const runs = await TaskRunService.listByTaskId(id);
     return c.json({
         ...task,
-        _resultPresentation: task.resultLog ? presentRunLog(task.resultLog) : null,
+        _resultPresentation: task.resultLog ? presentRunLog(task.resultLog, task.status !== 'done') : null,
         _runs: runs,
     });
 });
diff --git a/tests/dashboard-security.test.ts b/tests/dashboard-security.test.ts
@@ -480,6 +480,24 @@ describe('Dashboard 安全边界', () => {
         expect(presented.errors).toEqual(['opencode 退出码 1']);
     });
 
+    test('成功执行的截断 JSONL 片段不显示为失败原因', () => {
+        const command = JSON.stringify({
+            type: 'supertask_command',
+            executable: 'opencode',
+            cwd: '/tmp/project',
+            args: ['run', '--agent', 'build', '--format', 'json', 'test'],
+        });
+        const output = JSON.stringify({
+            type: 'text',
+            part: { type: 'text', text: '任务完成' },
+        });
+
+        const presented = presentRunLog(`${command}\n截断的 JSON 字符串尾部"}}\n${output}`, false);
+
+        expect(presented.text).toBe('任务完成');
+        expect(presented.errors).toEqual([]);
+    });
+
     test('异常 Session ID 不生成终端命令', async () => {
         const task = await TaskService.add({ name: '异常会话', agent: 'a', prompt: 'p' });
         const run = await TaskRunService.create({ taskId: task.id, status: 'running' });
diff --git a/tests/update.test.ts b/tests/update.test.ts
@@ -1,5 +1,15 @@
 import { afterEach, describe, expect, test } from 'bun:test';
-import { chmodSync, existsSync, mkdirSync, mkdtempSync, readFileSync, realpathSync, rmSync, writeFileSync } from 'fs';
+import {
+    chmodSync,
+    existsSync,
+    mkdirSync,
+    mkdtempSync,
+    readFileSync,
+    readdirSync,
+    realpathSync,
+    rmSync,
+    writeFileSync,
+} from 'fs';
 import { tmpdir } from 'os';
 import { join } from 'path';
 import {
@@ -20,6 +30,7 @@ const originalEnv = {
     npmBin: process.env.SUPERTASK_NPM_BIN,
     cache: process.env.SUPERTASK_OPENCODE_CACHE_DIR,
     packageDir: process.env.SUPERTASK_PLUGIN_PACKAGE_DIR,
+    tmpDir: process.env.TMPDIR,
 };
 
 function restoreEnv(name: string, value: string | undefined): void {
@@ -35,6 +46,7 @@ afterEach(() => {
     restoreEnv('SUPERTASK_NPM_BIN', originalEnv.npmBin);
     restoreEnv('SUPERTASK_OPENCODE_CACHE_DIR', originalEnv.cache);
     restoreEnv('SUPERTASK_PLUGIN_PACKAGE_DIR', originalEnv.packageDir);
+    restoreEnv('TMPDIR', originalEnv.tmpDir);
 });
 
 function writePlugin(packageDir: string, version: string): void {
@@ -86,6 +98,45 @@ process.exit(1);
         });
     });
 
+    test('通过私有临时文件读取超过管道缓冲区的最终配置并在完成后清理', () => {
+        const dir = mkdtempSync(join(tmpdir(), 'supertask-doctor-large-config-'));
+        dirs.push(dir);
+        const packageDir = join(dir, 'package');
+        const temporaryRoot = join(dir, 'tmp');
+        const fakeOpencode = join(dir, 'opencode');
+        const stdoutStatFile = join(dir, 'stdout-stat.json');
+        writePlugin(packageDir, '0.1.31');
+        mkdirSync(temporaryRoot);
+        writeFileSync(fakeOpencode, `#!/usr/bin/env bun
+import { fstatSync, writeFileSync } from 'fs';
+const config = JSON.stringify({
+  plugin: ['opencode-supertask@0.1.31'],
+  agent: { large: { prompt: 'x'.repeat(128 * 1024) } },
+});
+const stdout = fstatSync(1);
+writeFileSync(${JSON.stringify(stdoutStatFile)}, JSON.stringify({
+  isFile: stdout.isFile(),
+  mode: stdout.mode & 0o777,
+}));
+process.stdout.write(stdout.isFile() ? config : config.slice(0, 64 * 1024));
+`);
+        chmodSync(fakeOpencode, 0o755);
+        process.env.SUPERTASK_OPENCODE_BIN = fakeOpencode;
+        process.env.SUPERTASK_PLUGIN_PACKAGE_DIR = packageDir;
+        process.env.TMPDIR = temporaryRoot;
+
+        expect(getOpenCodePluginDiagnostic()).toMatchObject({
+            ok: true,
+            spec: 'opencode-supertask@0.1.31',
+            version: '0.1.31',
+        });
+        expect(JSON.parse(readFileSync(stdoutStatFile, 'utf8'))).toEqual({
+            isFile: true,
+            mode: 0o600,
+        });
+        expect(readdirSync(temporaryRoot)).toEqual([]);
+    });
+
     test('诊断拒绝 latest，即使旧缓存目录仍可读取', () => {
         const dir = mkdtempSync(join(tmpdir(), 'supertask-doctor-latest-'));
         dirs.push(dir);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "opencode-supertask",`
`3`		`- "version": "0.1.37",`
	`3`	`+ "version": "0.1.38",`
`4`	`4`	`"description": "AI Agent 任务调度系统 — OpenCode 插件 + CLI + Gateway 常驻进程",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/plugin/supertask.js",`