feat(vector): add ability to provide a digest for haproxy#524
feat(vector): add ability to provide a digest for haproxy#524LaurentGoderre wants to merge 3 commits into
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2d51f79e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This follows the same pattern as the image syntax for the vector container
LaurentGoderre
force-pushed
the
haproxy-image-digest
branch
from
f2d51f7 to
9a1802e
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a1802e68f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Without `| default ""`, setting `haproxy.image.tag: null` (a common pattern when overriding with a digest-only image) makes `trim` receive nil and aborts template rendering before the digest branches run. Matches the `| default ""` guard already used by `vector.image`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pront
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5cd6535fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {{- else if hasPrefix "sha256:" $tag -}} | ||
| {{- printf "%s@%s" $repo $tag -}} | ||
|
|
||
| {{- /* Case 3: tag@digest combined syntax */ -}} | ||
| {{- else if contains "@sha256:" $tag -}} |
There was a problem hiding this comment.
When HAProxy users set haproxy.image.tag to one of the newly supported digest forms (sha256:... here, or tag@sha256:... in the next branch), the image renders correctly but haproxy.labels still emits app.kubernetes.io/version: {{ .Values.haproxy.image.tag | quote }}. Kubernetes label values may not contain : or @, so these advertised inputs make the Deployment metadata invalid whenever HAProxy is enabled; either avoid supporting digest syntax in tag or sanitize/omit the label for those cases.
Useful? React with 👍 / 👎.
2 participants
This follows the same pattern as the image syntax for the vector container