chore(ci): update GHCR cleanup workflow (#25037)

* chore(ci): improve GHCR cleanup workflow

- Add step to delete dated nightly tags older than 30 days, guarded
  against semver/release tags
- Increase test-runner cleanup batch size from 50 to 100
- Add continue-on-error to test-runner step
- Update workflow name and header comment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore(ci): replace gh CLI step with action for dated nightly cleanup

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* use ubuntu-24.04

* keep 30 nightlies

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: pront

.github/workflows/cleanup-ghcr-images.yml

@@ -2,39 +2,43 @@
 #
 # This workflow cleans up old images from GitHub Container Registry
 # to prevent unlimited storage growth. It runs weekly and removes:
-# 1. Untagged images from all packages (intermediate build artifacts)
-# 2. Old test-runner versions (keeps 50 most recent, deletes up to 50 oldest)
+# 1. Old dated nightly tags for vector (keeps last ~8)
+# 2. Old test-runner versions (keeps 5 most recent)
 
-name: Cleanup Untagged GHCR Images
+name: Cleanup GHCR Images
 
 on:
   schedule:
     # Run weekly on Sundays at 2 AM UTC
-    - cron: '0 2 * * 0'
+    - cron: "0 2 * * 0"
   workflow_dispatch:
 
 permissions:
-  contents: read  # Restrictive default
+  contents: read # Restrictive default
 
 jobs:
-  cleanup:
-    runs-on: ubuntu-latest
+  cleanup-vector-nightlies:
+    runs-on: ubuntu-24.04
     permissions:
-      packages: write   # Required to delete package versions from GHCR
+      packages: write # Required to delete package versions from GHCR
     steps:
-      - name: Delete untagged vector images
+      - name: Delete old dated nightly vector images
         uses: actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
         with:
           package-name: vector
           package-type: container
-          min-versions-to-keep: 0
-          delete-only-untagged-versions: true
-        continue-on-error: true
+          min-versions-to-keep: 30
+          ignore-versions: '^(nightly$|\d+\.\d+)'
 
-      - name: Delete old vector-test-runner images
+  cleanup-test-runner:
+    runs-on: ubuntu-24.04
+    permissions:
+      packages: write # Required to delete package versions from GHCR
+    steps:
+      - name: Delete old test-runner images
         uses: actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
         with:
           package-name: test-runner
           package-type: container
           min-versions-to-keep: 5
-          num-old-versions-to-delete: 50
+          num-old-versions-to-delete: 100