fix(tag_cardinality_limit): reject cache_size_per_key in any non-probabilistic mode

Author: ArunPiduguDD

src/transforms/tag_cardinality_limit/config.rs

@@ -344,39 +344,40 @@ impl GenerateConfig for Config {
 #[derive(Debug, Snafu)]
 pub enum BuildError {
     #[snafu(display(
-        "cache_size_per_key set on per-tag entry `{tag_key}` but the inherited mode is \
-         `exact`, where it has no effect. Remove the field or switch to `probabilistic` mode."
+        "cache_size_per_key set on per-tag entry `{tag_key}` but the inherited mode is not \
+         `probabilistic`, where it has no effect. Remove the field or switch to `probabilistic` mode."
     ))]
-    CacheSizeInExactMode { tag_key: String },
+    CacheSizeRequiresProbabilistic { tag_key: String },
 }
 
 impl Config {
     fn validate(&self) -> crate::Result<()> {
-        // Global per_tag_limits: validate against the global mode.
-        if self.global.mode == Mode::Exact {
+        // Global per_tag_limits: cache_size_per_key only applies in probabilistic mode.
+        if !matches!(self.global.mode, Mode::Probabilistic(_)) {
             for (tag_key, tag_cfg) in &self.per_tag_limits {
                 if let PerTagMode::LimitOverride {
                     cache_size_per_key: Some(_),
                     ..
                 } = tag_cfg.mode
                 {
-                    return Err(Box::new(BuildError::CacheSizeInExactMode {
+                    return Err(Box::new(BuildError::CacheSizeRequiresProbabilistic {
                         tag_key: tag_key.clone(),
                     }));
                 }
             }
         }
 
-        // Per-metric per_tag_limits: validate against each per-metric mode.
+        // Per-metric per_tag_limits: cache_size_per_key only applies when the per-metric
+        // mode is probabilistic (not exact, and not excluded).
         for per_metric in self.per_metric_limits.values() {
-            if per_metric.config.mode == OverrideMode::Exact {
+            if !matches!(per_metric.config.mode, OverrideMode::Probabilistic(_)) {
                 for (tag_key, tag_cfg) in &per_metric.per_tag_limits {
                     if let PerTagMode::LimitOverride {
                         cache_size_per_key: Some(_),
                         ..
                     } = tag_cfg.mode
                     {
-                        return Err(Box::new(BuildError::CacheSizeInExactMode {
+                        return Err(Box::new(BuildError::CacheSizeRequiresProbabilistic {
                             tag_key: tag_key.clone(),
                         }));
                     }

src/transforms/tag_cardinality_limit/tests.rs

@@ -1646,6 +1646,28 @@ async fn validation_rejects_cache_size_in_per_metric_exact_mode() {
     assert!(config.build(&TransformContext::default()).await.is_err());
 }
 
+/// cache_size_per_key on a per-metric per-tag entry in excluded mode is a build error.
+#[tokio::test]
+async fn validation_rejects_cache_size_in_per_metric_excluded_mode() {
+    let config = make_transform_hashset_with_per_metric_limits(
+        500,
+        LimitExceededAction::DropTag,
+        HashMap::from([(
+            "metricA".to_string(),
+            make_per_metric_excluded(HashMap::from([(
+                "tag1".to_string(),
+                PerTagConfig {
+                    mode: PerTagMode::LimitOverride {
+                        value_limit: 5,
+                        cache_size_per_key: Some(1024),
+                    },
+                },
+            )])),
+        )]),
+    );
+    assert!(config.build(&TransformContext::default()).await.is_err());
+}
+
 /// cache_size_per_key in probabilistic mode is valid.
 #[tokio::test]
 async fn validation_allows_cache_size_in_probabilistic_mode() {