feat(ci): upload test results for make commands that use nextest (#24680)

* feat(ci): upload test results for make commands that produce nextest artifacts

* delete cli.yml and use .github/workflows/test-make-command.yml

* remove stuff claude missed

* we probably should not upload for comment triggers

Author: pront

.github/workflows/changes.yml

@@ -52,8 +52,6 @@ on:
         value: ${{ jobs.source.outputs.test-yml }}
       integration-yml:
         value: ${{ jobs.source.outputs.integration-yml }}
-      cli-yml:
-        value: ${{ jobs.source.outputs.cli-yml }}
       test-make-command-yml:
         value: ${{ jobs.source.outputs.test-make-command-yml }}
       msrv-yml:
@@ -175,7 +173,6 @@ jobs:
       website_only: ${{ steps.filter.outputs.website == 'true' && steps.filter.outputs.not_website == 'false' }}
       test-yml: ${{ steps.filter.outputs.test-yml }}
       integration-yml: ${{ steps.filter.outputs.integration-yml }}
-      cli-yml: ${{ steps.filter.outputs.cli-yml }}
       test-make-command-yml: ${{ steps.filter.outputs.test-make-command-yml }}
       msrv-yml: ${{ steps.filter.outputs.msrv-yml }}
       cross-yml: ${{ steps.filter.outputs.cross-yml }}
@@ -265,9 +262,6 @@ jobs:
           integration-yml:
             - ".github/workflows/integration.yml"
             - ".github/workflows/changes.yml"
-          cli-yml:
-            - ".github/workflows/cli.yml"
-            - ".github/workflows/changes.yml"
           test-make-command-yml:
             - ".github/workflows/test-make-command.yml"
             - ".github/workflows/changes.yml"

.github/workflows/ci-review-trigger.yml

@@ -86,9 +86,11 @@ jobs:
 
   cli:
     if: startsWith(github.event.review.body, '/ci-run-all') || contains(github.event.review.body, '/ci-run-cli')
-    uses: ./.github/workflows/cli.yml
+    uses: ./.github/workflows/test-make-command.yml
     with:
       ref: ${{ github.event.review.commit_id }}
+      command: test-cli
+      job_name: CLI tests
     secrets: inherit
 
   make-test-behavior:

.github/workflows/cli.yml

@@ -47,8 +47,12 @@ jobs:
     secrets: inherit
 
   test-cli:
-    if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.cli-yml == 'true' }}
-    uses: ./.github/workflows/cli.yml
+    if: ${{ needs.changes.outputs.source == 'true' || needs.changes.outputs.test-make-command-yml == 'true' }}
+    uses: ./.github/workflows/test-make-command.yml
+    with:
+      command: test-cli
+      job_name: CLI tests
+      upload_test_results: true
     needs: changes
     secrets: inherit
 

.github/workflows/master_merge_queue.yml

@@ -15,6 +15,11 @@ on:
         description: 'Git ref to checkout'
         required: false
         type: string
+      upload_test_results:
+        description: 'Whether to upload nextest test results (for commands that use cargo nextest)'
+        required: false
+        type: boolean
+        default: false
 
 
 permissions:
@@ -37,4 +42,9 @@ jobs:
           rust: true
           protoc: true
           libsasl2: true
+          cargo-nextest: ${{ inputs.upload_test_results }}
+          datadog-ci: ${{ inputs.upload_test_results }}
       - run: make ${{ inputs.command }}
+      - name: Upload test results
+        run: scripts/upload-test-results.sh
+        if: ${{ always() && inputs.upload_test_results }}