feat(vdev): check Cargo.lock for changes after cargo check/clippy (#24935)

* feat(vdev): check Cargo.lock for changes after cargo check/clippy

* Only commit if no lockfile changes are detected

Author: thomasqueirozb

Cargo.lock

@@ -219,6 +219,7 @@ vector-vrl-functions = { path = "lib/vector-vrl/functions", default-features = f
 vrl = { git = "https://github.com/vectordotdev/vrl.git", branch = "main", default-features = false, features = ["arbitrary", "cli", "test", "test_framework", "stdlib-base"] }
 mock_instant = { version = "0.6" }
 serial_test = { version = "3.2" }
+strum = { version = "0.28", features = ["derive"] }
 
 [dependencies]
 cfg-if.workspace = true

Cargo.toml

@@ -42,7 +42,7 @@ serde_json.workspace = true
 serde-aux = { version = "4.5", optional = true }
 smallvec = { version = "1", default-features = false, features = ["union"] }
 snafu.workspace = true
-strum = { version = "0.26.3", features = ["derive"], optional = true }
+strum = { workspace = true, optional = true }
 syslog_loose = { version = "0.23", default-features = false, optional = true }
 tokio-util = { version = "0.7", default-features = false, features = ["codec"] }
 tokio = { workspace = true, features = ["full"] }

lib/codecs/Cargo.toml

@@ -7,4 +7,4 @@ publish = false
 license = "MPL-2.0"
 
 [dependencies]
-strum = { version = "0.27", features = ["derive"] }
+strum.workspace = true

lib/vector-vrl/category/Cargo.toml

@@ -42,6 +42,7 @@ tempfile.workspace = true
 toml.workspace = true
 toml_edit = "0.23"
 semver.workspace = true
+strum.workspace = true
 indoc.workspace = true
 git2 = { version = "0.20.4" }
 cfg-if.workspace = true

vdev/Cargo.toml

@@ -1,9 +1,9 @@
-use anyhow::Result;
-use std::ffi::OsString;
+use anyhow::{Result, bail};
+use std::{ffi::OsString, fs};
 
 use crate::{
     app,
-    utils::{command::ChainArgs as _, git},
+    utils::{command::ChainArgs as _, git, paths},
 };
 
 /// Check the Rust code for errors
@@ -20,11 +20,16 @@ pub struct Cli {
     fix: bool,
 }
 
+#[derive(strum::Display, strum::AsRefStr, Clone, Copy, Debug)]
+#[strum(serialize_all = "lowercase")]
+enum Tool {
+    Clippy,
+    Check,
+}
+
 impl Cli {
     /// Build the argument vector for cargo invocation.
-    fn build_args(&self) -> Vec<OsString> {
-        let tool = if self.clippy { "clippy" } else { "check" };
-
+    fn build_args(&self, tool: Tool) -> Vec<OsString> {
         let pre_args = if self.fix {
             vec!["--fix"]
         } else {
@@ -47,14 +52,30 @@ impl Cli {
             ]
         };
 
-        [tool, "--workspace", "--all-targets"]
+        [tool.as_ref(), "--workspace", "--all-targets"]
             .chain_args(feature_args)
             .chain_args(pre_args)
             .chain_args(clippy_args)
     }
 
     pub fn exec(self) -> Result<()> {
-        app::exec("cargo", self.build_args(), true)?;
+        let lock_file = paths::find_repo_root()?.join("Cargo.lock");
+        let lock_before = fs::read(&lock_file)?;
+
+        let tool = if self.clippy {
+            Tool::Clippy
+        } else {
+            Tool::Check
+        };
+
+        app::exec("cargo", self.build_args(tool), true)?;
+
+        let lock_after = fs::read(&lock_file)?;
+        if lock_before != lock_after {
+            bail!(
+                "Cargo.lock was modified by `cargo {tool}`. Please commit the updated Cargo.lock."
+            );
+        }
 
         // If --fix was used, check for changes and commit them.
         if self.fix {