chore(ci): remove Chocolatey from Windows bootstrap (#25254)

* chore(ci): remove Chocolatey from Windows bootstrap

Install protoc directly from the upstream GitHub release (matching the
pinned version used on Linux/macOS in scripts/environment/install-protoc.sh)
instead of going through Chocolatey. GNU make is already on the default
PATH of the windows-2025 runner image via C:\mingw64\bin, so no extra
install step is needed for it.

This eliminates the recurring "Chocolatey installed 0/0 packages"
failures caused by Chocolatey CDN blips, and pins the Windows build to
the same protoc version used on Linux/macOS.

Verified on the ci-sandbox repo:
- protoc resolves to $RUNNER_TEMP\protoc\bin\protoc.exe -> libprotoc 3.21.12
- make resolves to C:\mingw64\bin\make.exe -> GNU Make 4.4.1

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(ci): share install-protoc.sh across platforms

Extend the existing Linux/macOS protoc installer with MINGW/MSYS
platform detection and .exe handling, and have bootstrap-windows-2025.ps1
delegate to it via Git Bash. This replaces the inline PowerShell
download introduced earlier and makes all three platforms pin the same
protoc version from the same upstream source.

Also adds curl --retry 5 --retry-delay 10 --retry-all-errors so
transient download blips are retried without extra scaffolding.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(ci): drop curl --retry-all-errors for focal compatibility

The ghcr.io/cross-rs/* base images used by scripts/cross/Dockerfile are
Ubuntu 20.04 focal, which ships curl 7.68.x. --retry-all-errors was
added in curl 7.71.0, so it would be rejected as an unknown option and
break cross-target builds that run install-protoc.sh inside those
images.

Plain --retry 5 --retry-delay 10 still handles the transport-level
retries that cover the CDN blips we care about.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: pront

scripts/environment/bootstrap-windows-2025.ps1

@@ -2,32 +2,6 @@
 $ErrorActionPreference = "Stop"
 Set-StrictMode -Version Latest
 
-# Helper function to install choco packages with exponential backoff retry
-function Install-ChocoPackage {
-    param(
-        [string]$Package,
-        [int]$MaxRetries = 5
-    )
-
-    for ($attempt = 1; $attempt -le $MaxRetries; $attempt++) {
-        choco install $Package --execution-timeout=7200 -y
-        # Both `choco install` and `choco list` can exit 0 even on 5xx errors
-        # from the feed, so verify install by matching a "name|version" line
-        # in the list output. --limit-output strips headers/warnings.
-        if ((choco list --limit-output -e $Package) -match "^$([regex]::Escape($Package))\|") {
-            return
-        }
-
-        if ($attempt -lt $MaxRetries) {
-            $delay = 5 * [math]::Pow(2, $attempt)  # Exponential: 10, 20, 40, 80 seconds
-            Write-Host "choco install $Package failed (attempt $attempt of $MaxRetries). Retrying in $delay seconds..."
-            Start-Sleep -Seconds $delay
-        } else {
-            throw "choco install $Package failed after $MaxRetries attempts"
-        }
-    }
-}
-
 # Set up our Cargo path so we can do Rust-y things.
 echo "$HOME\.cargo\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
 
@@ -37,9 +11,19 @@ if ($env:RELEASE_BUILDER -ne "true") {
     bash scripts/environment/prepare.sh --modules=rustup
 }
 
-# Install Chocolatey packages with exponential backoff retry
-Install-ChocoPackage "make"
-Install-ChocoPackage "protoc"
+# Install protoc via the shared cross-platform script. It pins the same version
+# used on Linux/macOS and downloads directly from the upstream GitHub release,
+# so we avoid the recurring Chocolatey CDN failures.
+$ProtocInstallDir = Join-Path $env:RUNNER_TEMP "protoc-bin"
+bash scripts/environment/install-protoc.sh "$ProtocInstallDir"
+if ($LASTEXITCODE -ne 0) {
+    throw "install-protoc.sh failed with exit code $LASTEXITCODE"
+}
+echo "$ProtocInstallDir" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+
+# GNU make is already on PATH on the windows-2025 runner image via the
+# pre-installed MinGW toolchain at C:\mingw64\bin, so no extra install is
+# needed here.
 
 # Set a specific override path for libclang.
 echo "LIBCLANG_PATH=$( (gcm clang).source -replace "clang.exe" )" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append

scripts/environment/install-protoc.sh

@@ -23,13 +23,12 @@ trap 'rm -rf "${TMP_DIR?}"' EXIT
 get_platform() {
   local os
   os=$(uname)
-  if [[ "${os}" == "Darwin" ]]; then
-    echo "osx"
-  elif [[ "${os}" == "Linux" ]]; then
-    echo "linux"
-  else
-    >&2 echo "unsupported os: ${os}" && exit 1
-  fi
+  case "${os}" in
+    Darwin) echo "osx" ;;
+    Linux) echo "linux" ;;
+    MINGW*|MSYS*|CYGWIN*) echo "win64" ;;
+    *) >&2 echo "unsupported os: ${os}" && exit 1 ;;
+  esac
 }
 
 get_arch() {
@@ -47,20 +46,36 @@ get_arch() {
   fi
 }
 
+get_bin_name() {
+  if [[ "$(get_platform)" == "win64" ]]; then
+    echo "protoc.exe"
+  else
+    echo "protoc"
+  fi
+}
+
 install_protoc() {
   local version=$1
   local install_path=$2
 
   local base_url="https://github.com/protocolbuffers/protobuf/releases/download"
   local url
-  url="${base_url}/v${version}/protoc-${version}-$(get_platform)-$(get_arch).zip"
+  if [[ "$(get_platform)" == "win64" ]]; then
+    # Windows release assets are named without an explicit arch suffix.
+    url="${base_url}/v${version}/protoc-${version}-win64.zip"
+  else
+    url="${base_url}/v${version}/protoc-${version}-$(get_platform)-$(get_arch).zip"
+  fi
   local download_path="${TMP_DIR}/protoc.zip"
 
   echo "Downloading ${url}"
-  curl -fsSL "${url}" -o "${download_path}"
+  # Stay compatible with the curl shipped by Ubuntu 20.04 focal (7.68.x) used
+  # in the ghcr.io/cross-rs/* base images: --retry-all-errors was only added
+  # in curl 7.71.0, so rely on the transport-level retry that --retry covers.
+  curl --retry 5 --retry-delay 10 -fsSL "${url}" -o "${download_path}"
 
   unzip -qq "${download_path}" -d "${TMP_DIR}"
-  mv -f -v "${TMP_DIR}/bin/protoc" "${install_path}"
+  mv -f -v "${TMP_DIR}/bin/$(get_bin_name)" "${install_path}"
 }
 
-install_protoc "21.12" "${INSTALL_PATH}/protoc"
+install_protoc "21.12" "${INSTALL_PATH}/$(get_bin_name)"