Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.d/24708_log_error.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The `opentelemetry` source now logs an error if it fails to start up or during runtime.
Comment thread
pront marked this conversation as resolved.
This can happen when the configuration is invalid, for example trying to bind to the wrong
IP or when hitting the open file limit.

authors: fbs
7 changes: 5 additions & 2 deletions src/sources/opentelemetry/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ impl SourceConfig for OpentelemetryConfig {
cx.shutdown.clone(),
)
.map_err(|error| {
error!(message = "Source future failed.", %error);
error!(message = "OpenTelemetry source gRPC server failed.", %error);
});

let http_tls_settings = MaybeTlsSettings::from_config(self.http.tls.as_ref(), true)?;
Expand All @@ -355,7 +355,10 @@ impl SourceConfig for OpentelemetryConfig {
filters,
cx.shutdown,
self.http.keepalive.clone(),
);
)
.map_err(|error| {
error!(message = "OpenTelemetry source HTTP server failed.", %error);
});

Ok(join(grpc_source, http_source).map(|_| Ok(())).boxed())
}
Expand Down
Loading