enhancement(host_metrics source): replace heim with sysinfo in network collector#24818
Open
mushrowan wants to merge 1 commit intovectordotdev:masterfrom
Open
enhancement(host_metrics source): replace heim with sysinfo in network collector#24818mushrowan wants to merge 1 commit intovectordotdev:masterfrom
mushrowan wants to merge 1 commit intovectordotdev:masterfrom
Conversation
github-actions
Bot
added
domain: sources
mushrowan
force-pushed
the
feat/host-metrics-network-sysinfo
branch
from
fd5bc2a to
46660f8
Compare
…ollector replace heim::net::io_counters() with sysinfo::Networks for network metrics collection, as part of removing the unmaintained heim dependency (vectordotdev#23646) - sysinfo already a dep (used by process.rs), no new dependencies - network_transmit_packets_total now emitted on all platforms (was linux/windows only behind heim IoCountersExt) - tx drop counters read from sysfs on linux since sysinfo doesn't expose them yet (same /sys/class/net dir sysinfo reads from) - windows tx drops temporarily unavailable, pending upstream sysinfo - replaces async stream/filter_map chain with simple sync iteration
mushrowan
force-pushed
the
feat/host-metrics-network-sysinfo
branch
from
46660f8 to
3a386c6
Compare
9 tasks
mushrowan
changed the title
Comment on lines
+76
to
+83
| #[cfg(target_os = "linux")] | ||
| fn read_sysfs_tx_dropped(interface: &str) -> Option<u64> { | ||
| std::fs::read_to_string(format!( | ||
| "/sys/class/net/{interface}/statistics/tx_dropped" | ||
| )) | ||
| .ok() | ||
| .and_then(|s| s.trim().parse().ok()) | ||
| } |
Contributor
There was a problem hiding this comment.
heim reads this directly from /proc/net/dev in Linux. We also don't want to drop windows support for network_transmit_packets_drop_total. I'd be more confident in merging this in if this were part of upstream sysinfo. Is there an upstream tracking issue for this?
Exploring an idea: is it possible to use heim to get just this one metric? We can could remove it later of course.
Comment on lines
+1
to
+6
| The `host_metrics` source network collector now uses `sysinfo` instead of the | ||
| unmaintained `heim` crate. `network_transmit_packets_total` is now emitted on | ||
| all platforms (previously linux/windows only). Windows `network_transmit_packets_drop_total` | ||
| is temporarily unavailable pending upstream sysinfo support. | ||
|
|
||
| authors: mushrowan |
Contributor
There was a problem hiding this comment.
Suggested change
| The `host_metrics` source network collector now uses `sysinfo` instead of the | |
| unmaintained `heim` crate. `network_transmit_packets_total` is now emitted on | |
| all platforms (previously linux/windows only). Windows `network_transmit_packets_drop_total` | |
| is temporarily unavailable pending upstream sysinfo support. | |
| authors: mushrowan | |
| The `host_metrics` source now emits `network_transmit_packets_total` on all platforms | |
| (previously Linux and Windows only). Windows `network_transmit_packets_drop_total` | |
| is temporarily unavailable pending upstream sysinfo support. | |
| authors: mushrowan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replace
heim::net::io_counters()withsysinfo::Networksin the host_metricsnetwork collector. first step in removing the unmaintained heim dependency
(#23646). sysinfo is already a dep (used by
process.rs)network_transmit_packets_totalnow emitted on all platforms (was linux/windowsonly). windows tx drops temporarily unavailable since sysinfo doesn't expose
drop counters yet, linux drops preserved via inline sysfs read
Vector configuration
How did you test this PR?
cargo test -p vector --no-default-features --features sources-host_metrics sources::host_metrics::networkChange Type
Is this a breaking change?
Does this PR include user facing changes?
guidelines.
no-changeloglabel to this PR.References
Notes